Issue 7046052: Revert stubs that were added in r88040. We need proper interfaces around features that need to b...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7046052: Revert stubs that were added in r88040. We need proper interfaces around features that need to b... (Closed)

Created:
9 years, 6 months ago by jam

Modified:
9 years, 6 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, Satish

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Revert stubs that were added in r88040. We need proper interfaces around features that need to be compiled out, instead of adding stubs. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88374

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -225 lines)			Patch
M	build/common.gypi	View	1 chunk	+0 lines, -3 lines	0 comments	Download
D	chrome/browser/notifications/notification_stubs.cc	View	1 chunk	+0 lines, -176 lines	0 comments	Download
D	chrome/browser/task_manager/task_manager_notification_resource_provider_stub.cc	View	1 chunk	+0 lines, -11 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	3 chunks	+0 lines, -18 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	7 chunks	+9 lines, -17 lines	0 comments	Download

Total messages: 2 (0 generated)

Ben Goodger (Google)

9 years, 6 months ago (2011-06-08 18:30:40 UTC) #2

LGTM. Apologies if I've sent mixed messages here before.