Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: chrome/browser/resources/file_manager/js/file_manager.js

Issue 7046050: file manager: fix alignment of checkboxes and file names in detail list (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/resources/file_manager/css/file_manager.css ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // WK Bug 55728 is fixed on the chrome 12 branch but not on the trunk. 5 // WK Bug 55728 is fixed on the chrome 12 branch but not on the trunk.
6 // TODO(rginda): Enable this everywhere once we have a trunk-worthy fix. 6 // TODO(rginda): Enable this everywhere once we have a trunk-worthy fix.
7 const ENABLE_METADATA = true; 7 const ENABLE_METADATA = true;
8 8
9 // Thumbnail view is painful without the exif reader. 9 // Thumbnail view is painful without the exif reader.
10 const ENABLE_THUMBNAIL_VIEW = ENABLE_METADATA; 10 const ENABLE_THUMBNAIL_VIEW = ENABLE_METADATA;
(...skipping 964 matching lines...) Expand 10 before | Expand all | Expand 10 after
975 * 975 *
976 * Invoked by cr.ui.Table when a file needs to be rendered. 976 * Invoked by cr.ui.Table when a file needs to be rendered.
977 * 977 *
978 * @param {Entry} entry The Entry object to render. 978 * @param {Entry} entry The Entry object to render.
979 * @param {string} columnId The id of the column to be rendered. 979 * @param {string} columnId The id of the column to be rendered.
980 * @param {cr.ui.Table} table The table doing the rendering. 980 * @param {cr.ui.Table} table The table doing the rendering.
981 */ 981 */
982 FileManager.prototype.renderName_ = function(entry, columnId, table) { 982 FileManager.prototype.renderName_ = function(entry, columnId, table) {
983 var label = this.document_.createElement('div'); 983 var label = this.document_.createElement('div');
984 label.entry = entry; 984 label.entry = entry;
985 label.className = 'filename-label'; 985 label.className = 'detail-name filename-label';
rginda 2011/06/08 17:35:58 The detail-name class was accidentally removed in
986 if (this.currentDirEntry_.name == '') { 986 if (this.currentDirEntry_.name == '') {
987 label.textContent = this.getLabelForRootPath_(entry.name); 987 label.textContent = this.getLabelForRootPath_(entry.name);
988 } else { 988 } else {
989 label.textContent = entry.name; 989 label.textContent = entry.name;
990 } 990 }
991 991
992 return label; 992 return label;
993 }; 993 };
994 994
995 /** 995 /**
(...skipping 1140 matching lines...) Expand 10 before | Expand all | Expand 10 after
2136 } else if (this.dialogType_ == FileManager.DialogType.SELECT_OPEN_FILE) { 2136 } else if (this.dialogType_ == FileManager.DialogType.SELECT_OPEN_FILE) {
2137 if (!this.selection.leadEntry.isFile) 2137 if (!this.selection.leadEntry.isFile)
2138 throw new Error('Selected entry is not a file!'); 2138 throw new Error('Selected entry is not a file!');
2139 } 2139 }
2140 2140
2141 chrome.fileBrowserPrivate.selectFile(ary[0], 0); 2141 chrome.fileBrowserPrivate.selectFile(ary[0], 0);
2142 window.close(); 2142 window.close();
2143 }; 2143 };
2144 2144
2145 })(); 2145 })();
OLDNEW
« no previous file with comments | « chrome/browser/resources/file_manager/css/file_manager.css ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698