Issue 7046050: file manager: fix alignment of checkboxes and file names in detail list

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7046050: file manager: fix alignment of checkboxes and file names in detail list (Closed)

Created:
9 years, 6 months ago by rginda

Modified:
9 years, 6 months ago

Reviewers:
achuithb

CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews), achuith+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

file manager: fix alignment of checkboxes and file names in detail list BUG=chromium-os:16264 TEST=manual testing in chromeos-chrome on linux Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88395

Patch Set 2 : use classList.contains to check for filename-label #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	chrome/browser/resources/file_manager/css/file_manager.css	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/resources/file_manager/js/file_manager.js	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rginda

http://codereview.chromium.org/7046050/diff/1/chrome/browser/resources/file_manager/js/file_manager.js File chrome/browser/resources/file_manager/js/file_manager.js (right): http://codereview.chromium.org/7046050/diff/1/chrome/browser/resources/file_manager/js/file_manager.js#newcode985 chrome/browser/resources/file_manager/js/file_manager.js:985: label.className = 'detail-name filename-label'; The detail-name class was accidentally ...

9 years, 6 months ago (2011-06-08 17:35:57 UTC) #1

achuithb

9 years, 6 months ago (2011-06-08 20:16:31 UTC) #2

LGTM.

On 2011/06/08 17:35:57, rginda wrote:
>
http://codereview.chromium.org/7046050/diff/1/chrome/browser/resources/file_m...
> File chrome/browser/resources/file_manager/js/file_manager.js (right):
> 
>
http://codereview.chromium.org/7046050/diff/1/chrome/browser/resources/file_m...
> chrome/browser/resources/file_manager/js/file_manager.js:985: label.className
=
> 'detail-name filename-label';
> The detail-name class was accidentally removed in a previous CL.  Re-adding it
> brings back the appropriate padding.

Expand Messages | Collapse Messages

Issue 7046050: file manager: fix alignment of checkboxes and file names in detail list (Closed)

Description

Patch Set 1 #

Patch Set 2 : use classList.contains to check for filename-label #

Messages