Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7046048: Roll clang 131950:132735 (Closed)

Created:
9 years, 6 months ago by Nico
Modified:
9 years, 6 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews, fischman+watch_chromium.org, pam+watch_chromium.org, ukai+watch_chromium.org
Visibility:
Public.

Description

Roll clang 131950:132735 Notable changes in the range: * r132735 (hopefully) fixes a bug introduced in r131951 that made gold 1.10 crash with /usr/bin/ld: internal error in set_offset, at output.cc:4030 * r132535 fixes the crash at -O3 on mac * r132565 adds a warning for "x + y ? a : b" to -Wparentheses BUG=85289, 84424 TEST=none TBR=evan Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88344

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M build/common.gypi View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M tools/clang/scripts/update.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Nico
The parentheses warning is in webkit, which is why I don't want to wait with ...
9 years, 6 months ago (2011-06-08 16:35:08 UTC) #1
Evan Martin
9 years, 6 months ago (2011-06-08 16:57:58 UTC) #2 
LGTM
On Wed, Jun 8, 2011 at 9:35 AM,  <thakis@chromium.org> wrote:
> Reviewers: Evan Martin,
>
> Message:
> The parentheses warning is in webkit, which is why I don't want to wait with
> rolling:
>
>
/b/build/slave/mac_clang/build/src/third_party/WebKit/Source/WebCore/WebCore.gyp/../platform/chromium/ScrollbarThemeChromiumMac.mm:248:118:error:
> ?: has lower precedence than +; + will be evaluated first
> [-Werror,-Wparentheses]
>            result = IntRect(scrollbar->x(), scrollbar->y(),
> cOuterButtonLength[scrollbar->controlSize()] + painting ?
> cOuterButtonOverlap :
> 0, thickness);
>
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
>
/b/build/slave/mac_clang/build/src/third_party/WebKit/Source/WebCore/WebCore.gyp/../platform/chromium/ScrollbarThemeChromiumMac.mm:248:118:
> note: place parentheses around the + expression to silence this warning
>            result = IntRect(scrollbar->x(), scrollbar->y(),
> cOuterButtonLength[scrollbar->controlSize()] + painting ?
> cOuterButtonOverlap :
> 0, thickness);
>
>                                    ^
>                                                             (
>                                   )
>
/b/build/slave/mac_clang/build/src/third_party/WebKit/Source/WebCore/WebCore.gyp/../platform/chromium/ScrollbarThemeChromiumMac.mm:248:118:
> note: place parentheses around the ?: expression to evaluate it first
>            result = IntRect(scrollbar->x(), scrollbar->y(),
> cOuterButtonLength[scrollbar->controlSize()] + painting ?
> cOuterButtonOverlap :
> 0, thickness);
>
>                                    ^
>
>                           (                                 )
>
/b/build/slave/mac_clang/build/src/third_party/WebKit/Source/WebCore/WebCore.gyp/../platform/chromium/ScrollbarThemeChromiumMac.mm:250:129:error:
> ?: has lower precedence than +; + will be evaluated first
> [-Werror,-Wparentheses]
>            result = IntRect(scrollbar->x(), scrollbar->y(), thickness,
> cOuterButtonLength[scrollbar->controlSize()] + painting ?
> cOuterButtonOverlap :
> 0);
>
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
>
/b/build/slave/mac_clang/build/src/third_party/WebKit/Source/WebCore/WebCore.gyp/../platform/chromium/ScrollbarThemeChromiumMac.mm:250:129:
> note: place parentheses around the + expression to silence this warning
>            result = IntRect(scrollbar->x(), scrollbar->y(), thickness,
> cOuterButtonLength[scrollbar->controlSize()] + painting ?
> cOuterButtonOverlap :
> 0);
>
>                                               ^
>                                                                        (
>                                              )
>
/b/build/slave/mac_clang/build/src/third_party/WebKit/Source/WebCore/WebCore.gyp/../platform/chromium/ScrollbarThemeChromiumMac.mm:250:129:
> note: place parentheses around the ?: expression to evaluate it first
>            result = IntRect(scrollbar->x(), scrollbar->y(), thickness,
> cOuterButtonLength[scrollbar->controlSize()] + painting ?
> cOuterButtonOverlap :
> 0);
>
>                                               ^
>
>                                      (                                 )
> 2 errors generated.
>
> Description:
> Roll clang 131950:132735
>
> Notable changes in the range:
> * r132735 (hopefully) fixes a bug introduced in r131951 that made
>  gold 1.10 crash with
>     /usr/bin/ld: internal error in set_offset, at output.cc:4030
> * r132535 fixes the crash at -O3 on mac
> * r132565 adds a warning for "x + y ? a : b" to -Wparentheses
>
> BUG=85289,84424
> TEST=none
>
>
> Please review this at http://codereview.chromium.org/7046048/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M build/common.gypi
>  M tools/clang/scripts/update.sh
>
>
> Index: build/common.gypi
> diff --git a/build/common.gypi b/build/common.gypi
> index
>
be71ad235fd6e39d6e46d28d14996996b66ee830..73d12b6200ee68b192375583b4e209f03d2a4bc8
> 100644
> --- a/build/common.gypi
> +++ b/build/common.gypi
> @@ -1364,7 +1364,7 @@
>                   # are fixed in the views and chromeos code.
>                   # http://crbug.com/84424
>                   # TODO(thakis): Add back in when rolling clang past
> r131989
> -                  #'-Wno-delete-non-virtual-dtor',
> +                  '-Wno-delete-non-virtual-dtor',
>                 ],
>               }]],
>           }],
> Index: tools/clang/scripts/update.sh
> diff --git a/tools/clang/scripts/update.sh b/tools/clang/scripts/update.sh
> index
>
90d2be0d058eec7e9c84fe7e13d0df53d56d6462..eda73fe2f5e3859f676d43849702c71ef7e53fa7
> 100755
> --- a/tools/clang/scripts/update.sh
> +++ b/tools/clang/scripts/update.sh
> @@ -5,7 +5,7 @@
>
>  # This script will check out llvm and clang into third_party/llvm and build
> it.
>
> -CLANG_REVISION=131950
> +CLANG_REVISION=132735
>
>  THIS_DIR="$(dirname "${0}")"
>  LLVM_DIR="${THIS_DIR}"/../../../third_party/llvm
>
>
>

Powered by Google App Engine
This is Rietveld 408576698