Issue 7046036: Remove obsolete suppression for 60890.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7046036: Remove obsolete suppression for 60890. (Closed)

Created:
9 years, 6 months ago by mattm

Modified:
9 years, 6 months ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Remove obsolete suppression for 60890. BUG=60890 TEST=memory bots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88463

Patch Set 1 #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -12 lines)			Patch
	M	tools/valgrind/memcheck/suppressions.txt	View		1 chunk	+0 lines, -12 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

mattm

Seems likely this was resolved by the leaking of NSS (crbug/61585). Hasn't shown up on ...

9 years, 6 months ago (2011-06-08 01:02:49 UTC) #1

willchan no longer on Chromium

9 years, 6 months ago (2011-06-08 05:33:25 UTC) #2

OK, LGTM

On Wed, Jun 8, 2011 at 2:02 AM,  <mattm@chromium.org> wrote:
> Reviewers: willchan,
>
> Message:
> Seems likely this was resolved by the leaking of NSS (crbug/61585).  Hasn't
> shown up on the bots in ~80 runs I grepped.  In addition the
> AutomationProxyTest
> tests that seemed to trigger it have since been removed
> (http://codereview.chromium.org/7104029)
>
> Description:
> Remove obsolete suppression for 60890.
>
> BUG=60890
> TEST=memory bots
>
>
> Please review this at http://codereview.chromium.org/7046036/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M tools/valgrind/memcheck/suppressions.txt
>
>
> Index: tools/valgrind/memcheck/suppressions.txt
> diff --git a/tools/valgrind/memcheck/suppressions.txt
> b/tools/valgrind/memcheck/suppressions.txt
> index
>
0c0b39a28650e7823f21719558236195170f7ae6..81ad0bb931941d8062bbbb28fd6fb7276aa0dc10
> 100644
> --- a/tools/valgrind/memcheck/suppressions.txt
> +++ b/tools/valgrind/memcheck/suppressions.txt
> @@ -3092,18 +3092,6 @@
>
>
 fun:_ZN7history20VisitSegmentDatabase17QuerySegmentUsageEN4base4TimeEiPSt6vectorIP13PageUsageDataSaIS5_EE
>  }
>  {
> -   bug_60890
> -   Memcheck:Jump
> -   ...
> -   fun:find_objects
> -   fun:find_objects_by_template
> -   fun:nssToken_FindCertificatesBySubject
> -   fun:nssTrustDomain_FindCertificatesBySubject
> -   fun:nssCertificate_BuildChain
> -   fun:NSSCertificate_BuildChain
> -   fun:CERT_FindCertIssuer
> -}
> -{
>    bug_69073
>    Memcheck:Leak
>    fun:malloc
>
>
>

Expand Messages | Collapse Messages