Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2754)

Unified Diff: content/common/gpu/omx_video_decode_accelerator.cc

Issue 7046031: OmxVideoDecodeAcceleratorTest improvements: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/gpu/omx_video_decode_accelerator.cc
diff --git a/content/common/gpu/omx_video_decode_accelerator.cc b/content/common/gpu/omx_video_decode_accelerator.cc
index 80b3bba8f1cf58390a6abf7725643748caf949f6..7c10e698bb80de1288e9990fe06835be24ef5dd2 100644
--- a/content/common/gpu/omx_video_decode_accelerator.cc
+++ b/content/common/gpu/omx_video_decode_accelerator.cc
@@ -128,16 +128,9 @@ bool OmxVideoDecodeAccelerator::Initialize(const std::vector<uint32>& config) {
return false;
}
- // After AllocateInputBuffers ideally this should be AllocateOutputBuffers.
- // Since in this case app provides the output buffers,
- // we query this through ProvidePictureBuffers.
- // This is call to ppapi to provide the output buffers initially.
- // ProvidePictureBuffers will provide
- // - SharedMemHandle in case of decoding to system memory.
- // - Textures in case of decoding to egl-images.
-
- // Output buffers will be eventually handed to us via
- // Assign{GLES,Sysmem}Buffers().
+ // In order to allocate output buffers we need to have textures in hand, so we
+ // call ProvidePictureBuffers on the client and complete initialization in
+ // AssignGLESBuffers.
message_loop_->PostTask(
FROM_HERE,
base::Bind(&Client::ProvidePictureBuffers, base::Unretained(client_),

Powered by Google App Engine
This is Rietveld 408576698