Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 7046023: Revert 84329 - 2011-04-19 Julien Chaffraix <jchaffraix@codeaurora.org> (Closed)

Created:
9 years, 6 months ago by Nico
Modified:
9 years, 6 months ago
Reviewers:
commit-queue
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/782/
Visibility:
Public.

Description

Revert 84329 - 2011-04-19 Julien Chaffraix <jchaffraix@codeaurora.org>; Reviewed by Alexey Proskuryakov. https://bugs.webkit.org/show_bug.cgi?id=45425 HTMLLinkElement.disabled does not forward value to the Stylesheet's disabled attribute on setting Test case by Bijan Amirzada <bijana@codeaurora.org>;. * fast/dom/HTMLLinkElement/disabled-attribute-expected.txt: Added. * fast/dom/HTMLLinkElement/disabled-attribute.html: Added. Test that the properties are properly forwarded to the stylesheet. * fast/dom/boolean-attribute-reflection-expected.txt: * fast/dom/script-tests/boolean-attribute-reflection.js: Removed link:disabled as it is not reflected anymore. 2011-04-19 Julien Chaffraix <jchaffraix@codeaurora.org>; Reviewed by Alexey Proskuryakov. https://bugs.webkit.org/show_bug.cgi?id=45425 HTMLLinkElement.disabled does not forward value to the Stylesheet's disabled attribute on setting Test: fast/html/htmllink-disable.html Test: fast/dom/HTMLLinkElement/disabled-attribute.html Match the HTML5 specification by forwarding the 'disabled' attribute to our stylesheet. Based on previous work by Bijan Amirzada <bijana@codeaurora.org>;. * html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::disabled): Return our stylesheet's 'disabled' value or false if we don't have a stylesheet. (WebCore::HTMLLinkElement::setDisabled): Set our stylesheet's 'disabled' value or ignore the call if we don't have a stylesheet. * html/HTMLLinkElement.h: * html/HTMLLinkElement.idl: Remove 'Reflect' as it is not a reflected attribute anymore in HTML5. This matches the way FF4, Opera and IE9 handle the attribute. TBR=commit-queue@webkit.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88252

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -80 lines) Patch
D LayoutTests/fast/dom/HTMLLinkElement/disabled-attribute.html View 1 chunk +0 lines, -46 lines 0 comments Download
D LayoutTests/fast/dom/HTMLLinkElement/disabled-attribute-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
M LayoutTests/fast/dom/boolean-attribute-reflection-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/script-tests/boolean-attribute-reflection.js View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/html/HTMLLinkElement.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/html/HTMLLinkElement.cpp View 1 chunk +0 lines, -12 lines 0 comments Download
M Source/WebCore/html/HTMLLinkElement.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Nico
9 years, 6 months ago (2011-06-07 19:08:54 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698