I added a function "void SpdySettingsStorage::Clear()". I added a call to this function "spdy_set...

net/spdy/spdy_settings_storage.h

Index: net/spdy/spdy_settings_storage.h
===================================================================
--- net/spdy/spdy_settings_storage.h	(revision 85710)
+++ net/spdy/spdy_settings_storage.h	(working copy)
@@ -22,12 +22,18 @@
 
   // Get a copy of the SpdySettings stored for a host.
   // If no settings are stored, returns an empty set of settings.
+  // Since settings_map_ may be cleared, don't remember the address of the
+  // return value.
+

[wtc, 2011/05/19 22:54:37]

Nit: don't add this blank line.

willchan: since Get() returns a (const) reference to a value
in settings_map_, a caller may store the reference, which
will become invalid after a Clear() call.

We can eliminating this risk entirely by changing Get() to
return a copy of the value, but since the value (spdy::SpdySettings)
is an std::list, it seems expensive to always copy it.
So rkn and I decided to add this comment to warn the callers.
rkn verified that no existing callers store the returned
reference.

[willchan no longer on Chromium, 2011/05/19 22:59:44]

Adding a comment is indeed the right solution here.

   const spdy::SpdySettings& Get(const HostPortPair& host_port_pair) const;
 
   // Save settings for a host.
   void Set(const HostPortPair& host_port_pair,
            const spdy::SpdySettings& settings);
 
+  // Flush structure

[wtc, 2011/05/19 22:54:37]

Nit: this comment should say a little more.

+  void Clear();
+
  private:
   typedef std::map<HostPortPair, spdy::SpdySettings> SettingsMap;