I added a function "void SpdySettingsStorage::Clear()". I added a call to this function "spdy_set...

net/spdy/spdy_session_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/spdy/spdy_session.h"
 
 #include "net/spdy/spdy_io_buffer.h"
 #include "net/spdy/spdy_session_pool.h"
 #include "net/spdy/spdy_stream.h"
 #include "net/spdy/spdy_test_util.h"
@@ skipping 509 matching lines @@
 }
 
 TEST_F(SpdySessionTest, IPPooling) {
   IPPoolingTest(false);
 }
 
 TEST_F(SpdySessionTest, IPPoolingCloseCurrentSessions) {
   IPPoolingTest(true);
 }
 
+TEST_F(SpdySessionTest, ClearSettingsStorage) {
+  SpdySettingsStorage new_settings_storage;

[wtc, 2011/05/21 01:38:33]

Nit: please remove "new_" from the variable name.

[rkn1, 2011/05/21 01:54:40]

Done.

+  const std::string kTestHost("www.foo.com");
+  const int kTestPort = 80;
+  HostPortPair test_host_port_pair(kTestHost, kTestPort);
+  spdy::SpdySettings test_settings;
+  spdy::SettingsFlagsAndId id(spdy::SETTINGS_FLAG_PLEASE_PERSIST);
+  id.set_id(spdy::SETTINGS_FLAG_PLEASE_PERSIST);

[wtc, 2011/05/21 01:38:33]

This comment also applies to the next unit test.

I believe we also need to specify which setting this is.
See lines 279-281.

So we should do:
  spdy::SettingsFlagsAndId id(spdy::SETTINGS_MAX_CONCURRENT_STREAMS);
  id.set_id(spdy::SETTINGS_MAX_CONCURRENT_STREAMS);
  id.set_flags(spdy::SETTINGS_FLAG_PLEASE_PERSIST);

Note: I don't understand why we pass
spdy::SETTINGS_MAX_CONCURRENT_STREAMS twice.
  

[rkn1, 2011/05/21 01:54:40]

Done.

+  const size_t max_concurrent_streams = 2;
+  test_settings.push_back(spdy::SpdySetting(id, max_concurrent_streams));
+
+  new_settings_storage.Set(test_host_port_pair, test_settings);
+  EXPECT_NE(0u, new_settings_storage.Get(test_host_port_pair).size());
+  new_settings_storage.Clear();
+  EXPECT_EQ(0u, new_settings_storage.Get(test_host_port_pair).size());
+}
+
+TEST_F(SpdySessionTest, ClearSettingsStorageOnIPAddressChanged) {
+  const std::string kTestHost("www.foo.com");
+  const int kTestPort = 80;
+  HostPortPair test_host_port_pair(kTestHost, kTestPort);
+  HostPortProxyPair pair(test_host_port_pair, ProxyServer::Direct());

[wtc, 2011/05/21 01:38:33]

Delete this line.  The 'pair' variable is not used.

[rkn1, 2011/05/21 01:54:40]

Done.

+
+  SpdySessionDependencies session_deps;
+  scoped_refptr<HttpNetworkSession> http_session(
+      SpdySessionDependencies::SpdyCreateSession(&session_deps));
+  SpdySessionPool* spdy_session_pool(http_session->spdy_session_pool());
+
+  SpdySettingsStorage* test_settings_storage =
+      spdy_session_pool->mutable_spdy_settings();
+  spdy::SettingsFlagsAndId id(spdy::SETTINGS_FLAG_PLEASE_PERSIST);
+  const size_t max_concurrent_streams = 2;
+  spdy::SpdySettings test_settings;
+  test_settings.push_back(spdy::SpdySetting(id, max_concurrent_streams));
+
+  test_settings_storage->Set(test_host_port_pair, test_settings);
+  EXPECT_NE(0u, test_settings_storage->Get(test_host_port_pair).size());
+  spdy_session_pool->OnIPAddressChanged();
+  EXPECT_EQ(0u, test_settings_storage->Get(test_host_port_pair).size());
+}
+
 }  // namespace
 
 }  // namespace net