I added a function "void SpdySettingsStorage::Clear()". I added a call to this function "spdy_set...

net/spdy/spdy_session_pool.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/spdy/spdy_session_pool.h"
 
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "base/values.h"
 #include "net/base/address_list.h"
@@ skipping 159 matching lines @@
     for (SpdySessionList::const_iterator session = sessions->begin();
          session != sessions->end(); ++session) {
       list->Append(session->get()->GetInfoAsValue());
     }
   }
   return list;
 }
 
 void SpdySessionPool::OnIPAddressChanged() {
   CloseCurrentSessions();
+  spdy_settings_.Clear();
 }

[rkn1, 2011/05/20 16:57:37]

willchan: Is there a good way to test this function?

Also, you mentioned unifying everything that needs to be flushed in a single
struct, can you elaborate on what would need to be done?

[willchan no longer on Chromium, 2011/05/20 21:29:47]

OnIPAddressChanged() is a public method so you can call it from tests easily.
You can get a non-const SpdySettingsStorage via
SpdySessionPool::mutable_spdy_settings(). Modify the SpdySettingsStorage, then
call SpdySessionPool::OnIPAddressChanged() and then verify that it's empty.

 
 void SpdySessionPool::OnSSLConfigChanged() {
   CloseCurrentSessions();
 }
 
 scoped_refptr<SpdySession> SpdySessionPool::GetExistingSession(
     SpdySessionList* list,
     const BoundNetLog& net_log) const {
   DCHECK(list);
   DCHECK_LT(0u, list->size());
@@ skipping 211 matching lines @@
       delete list;
       RemoveAliases(old_map.begin()->first);
       old_map.erase(old_map.begin()->first);
     }
   }
   DCHECK(sessions_.empty());
   DCHECK(aliases_.empty());
 }
 
 }  // namespace net