Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: chrome/browser/browsing_data_database_helper.h

Issue 7046013: Use the DatabaseTracker only on the FILE thread. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/browsing_data_database_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browsing_data_database_helper.h
===================================================================
--- chrome/browser/browsing_data_database_helper.h (revision 85641)
+++ chrome/browser/browsing_data_database_helper.h (working copy)
@@ -18,7 +18,7 @@
class Profile;
-// This class fetches database information in the WEBKIT thread, and notifies
+// This class fetches database information in the FILE thread, and notifies
// the UI thread upon completion.
// A client of this class need to call StartFetching from the UI thread to
// initiate the flow, and it'll be notified by the callback in its UI
@@ -64,7 +64,7 @@
// This must be called only in the UI thread.
virtual void CancelNotification();
- // Requests a single database to be deleted in the WEBKIT thread. This must be
+ // Requests a single database to be deleted in the FILE thread. This must be
// called in the UI thread.
virtual void DeleteDatabase(const std::string& origin,
const std::string& name);
@@ -76,7 +76,7 @@
// Notifies the completion callback. This must be called in the UI thread.
void NotifyInUIThread();
- // This only mutates in the WEBKIT thread.
+ // This only mutates in the FILE thread.
std::vector<DatabaseInfo> database_info_;
// This only mutates on the UI thread.
@@ -90,11 +90,11 @@
bool is_fetching_;
private:
- // Enumerates all databases. This must be called in the WEBKIT thread.
- void FetchDatabaseInfoInWebKitThread();
+ // Enumerates all databases. This must be called in the FILE thread.
+ void FetchDatabaseInfoOnFileThread();
- // Delete a single database file. This must be called in the WEBKIT thread.
- void DeleteDatabaseInWebKitThread(const std::string& origin,
+ // Delete a single database file. This must be called in the FILE thread.
+ void DeleteDatabaseOnFileThread(const std::string& origin,
const std::string& name);
scoped_refptr<webkit_database::DatabaseTracker> tracker_;
« no previous file with comments | « no previous file | chrome/browser/browsing_data_database_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698