Fix bug with long stack traces truncation in DevTools CPU profiler.

Fix bug with long stack traces truncation in DevTools CPU profiler.

R=sgjesse@chromium.org,vitalyr@chromium.org
BUG=1398
TEST=cctest/test-cpu-profiler/Issue1398

Committed: http://code.google.com/p/v8/source/detail?r=7949

[Søren Thygesen Gjesse, 2011-05-19 07:36:03]

LGTM

[Vitaly Repeshko, 2011-05-19 11:31:01]

http://codereview.chromium.org/7046001/diff/1/test/cctest/test-cpu-profiler.cc
File test/cctest/test-cpu-profiler.cc (right):

http://codereview.chromium.org/7046001/diff/1/test/cctest/test-cpu-profiler.c...
test/cctest/test-cpu-profiler.cc:250: while (!processor.running()) {
ProfilerEventsProcessor sets "running" to true in the constructor. Do we need
this loop (here and in other places in this file)? If yes, can we replace it
with a semaphore?

[mnaganov (inactive), 2011-05-19 11:43:40]

On 2011/05/19 11:31:01, Vitaly Repeshko wrote:
> http://codereview.chromium.org/7046001/diff/1/test/cctest/test-cpu-profiler.cc
> File test/cctest/test-cpu-profiler.cc (right):
> 
>
http://codereview.chromium.org/7046001/diff/1/test/cctest/test-cpu-profiler.c...
> test/cctest/test-cpu-profiler.cc:250: while (!processor.running()) {
> ProfilerEventsProcessor sets "running" to true in the constructor. Do we need
> this loop (here and in other places in this file)? If yes, can we replace it
> with a semaphore?

Good catch!

No, we don't need it. Initially ProfilerEventsProcessor was setting it to 'true'
later (in the Run method), and the test code I've copied was written at that
time.

I will clean this up.