Use large bold font for associated network on touch.

Use large bold font for associated network on touch.

The CrOS network menu shows the associated network in bold face and non-associated networks in regular face.  The size of these fonts matches for non-touch builds but are different for touch builds.

BUG=none
TEST=on touch build, open network menu and check if all items are the same size


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89427

[rhashimoto, 2011-06-15 23:01:20]

Hi Scott -

When you recommended putting #ifdef TOUCH_UI configurations in browser_defaults,
I wasn't sure whether that extended to ChromiumOS configurations so I
implemented the associated network font in two ways.  Patchset 2 puts the
configuration in the CrOS file network_menu.cc, while Patchset 3 uses
browser_defaults.

Thanks,
Roy

[sky, 2011-06-16 15:00:48]

I like patchset 3. One question though. I'm wondering if you are going to end up
changing all call sites that use BoldFonts to use LargeBoldFonts. Are there
places currently where we use BoldFonts and you don't want to change them to
LargeBoldFonts?

  -Scott

http://codereview.chromium.org/7044121/diff/4001/chrome/browser/defaults.cc
File chrome/browser/defaults.cc (right):

http://codereview.chromium.org/7044121/diff/4001/chrome/browser/defaults.cc#n...
chrome/browser/defaults.cc:92: const ui::ResourceBundle::FontStyle
kCrOSAssociatedNetworkFont =
Make this end in Style, eg kCrOSAssociatedNetworkFontStyle. I'm also fine with
the shorter kNetworkFontStyle.

[rhashimoto, 2011-06-16 16:38:00]

On 2011/06/16 15:00:48, sky wrote:
> I'm wondering if you are going to end up
> changing all call sites that use BoldFonts to use LargeBoldFonts. Are there
> places currently where we use BoldFonts and you don't want to change them to
> LargeBoldFonts?

It looks like the other current uses of BoldFont are the active extension panel
title bar, the login screen, and the try chrome dialog.  Since the login screen
is being replaced with WebUI and the try dialog doesn't apply to ChromiumOS, the
only consideration is for panel titles.  I asked Emmanuel and he thinks we'll
leave this at the default size.

Thanks,
Roy

http://codereview.chromium.org/7044121/diff/4001/chrome/browser/defaults.cc
File chrome/browser/defaults.cc (right):

http://codereview.chromium.org/7044121/diff/4001/chrome/browser/defaults.cc#n...
chrome/browser/defaults.cc:92: const ui::ResourceBundle::FontStyle
kCrOSAssociatedNetworkFont =
On 2011/06/16 15:00:48, sky wrote:
> Make this end in Style, eg kCrOSAssociatedNetworkFontStyle. I'm also fine with
> the shorter kNetworkFontStyle.

Changed to kAssociatedNetworkFontStyle.

[sky, 2011-06-16 16:51:10]

LGTM

[commit-bot: I haz the power, 2011-06-17 00:03:51]

Change committed as 89427