Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 7044096: Throttle the touch move events sent to the renderer. (Closed)

Created:
9 years, 6 months ago by sadrul
Modified:
9 years, 6 months ago
Reviewers:
jam, sky
CC:
chromium-reviews, joi+watch-content_chromium.org, jam
Visibility:
Public.

Description

Throttle the touch move events sent to the renderer. Sending too many touch move events too quickly can overwhelm the renderer. So wait for an ACK from the renderer before sending out an event to maintain the renderer at just the right amount of whelm. The renderer already does the right thing, so it doesn't need to be updated. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88614

Patch Set 1 #

Total comments: 2

Patch Set 2 : nuke ifdefs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -4 lines) Patch
M content/browser/renderer_host/render_widget_host.h View 1 2 chunks +13 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host.cc View 1 4 chunks +24 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sadrul
9 years, 6 months ago (2011-06-09 21:28:15 UTC) #1
jam
why do you need both me and Scott? I'm not familiar with this code.
9 years, 6 months ago (2011-06-09 21:47:09 UTC) #2
sadrul
Ah. I added you for OWNERS, but now I see that Scott is in OWNERS ...
9 years, 6 months ago (2011-06-09 21:51:14 UTC) #3
sky
http://codereview.chromium.org/7044096/diff/1/content/browser/renderer_host/render_widget_host.cc File content/browser/renderer_host/render_widget_host.cc (right): http://codereview.chromium.org/7044096/diff/1/content/browser/renderer_host/render_widget_host.cc#newcode650 content/browser/renderer_host/render_widget_host.cc:650: #if defined(TOUCH_UI) De we need the ifdefs? If you're ...
9 years, 6 months ago (2011-06-09 21:58:12 UTC) #4
sadrul
http://codereview.chromium.org/7044096/diff/1/content/browser/renderer_host/render_widget_host.cc File content/browser/renderer_host/render_widget_host.cc (right): http://codereview.chromium.org/7044096/diff/1/content/browser/renderer_host/render_widget_host.cc#newcode650 content/browser/renderer_host/render_widget_host.cc:650: #if defined(TOUCH_UI) On 2011/06/09 21:58:12, sky wrote: > De ...
9 years, 6 months ago (2011-06-09 22:15:45 UTC) #5
sky
9 years, 6 months ago (2011-06-09 22:17:44 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld 408576698