Hooking MHTML generation to the browser.

base/platform_file.h

Index: base/platform_file.h
diff --git a/base/platform_file.h b/base/platform_file.h
index 5b29e07fa08084360710ed84d6ada7908cb764d2..34688cedc996139ce86c9f2488d4116ddde5e509 100644
--- a/base/platform_file.h
+++ b/base/platform_file.h
@@ -16,6 +16,7 @@
 #include "base/base_api.h"
 #include "base/basictypes.h"
 #include "base/file_path.h"
+#include "base/process.h"
 #include "base/time.h"
 
 namespace base {
@@ -140,6 +141,11 @@ BASE_API bool TouchPlatformFile(PlatformFile file, const Time& last_access_time,
 // Returns some information for the given file.
 BASE_API bool GetPlatformFileInfo(PlatformFile file, PlatformFileInfo* info);
 
+// Returns a file handle equivalent to |file| that can be used in |process|.
+BASE_API PlatformFile GetFileHandleForProcess(PlatformFile file,
+                                              ProcessHandle process,
+                                              bool close_source_handle);

[brettw, 2011/06/13 23:12:36]

I'm a little worried that close_source_handle only does something on Windows. It
seems like any code that sets this to true then must have some ifdefed code to
close the handle somehow on Posix.

Currently, what happens is that almost all code either sends the duplicated
handle over IPC on Windows, or converts it to a FileDescriptor on Posix which
then encompases the auto close semantics.

I wonder if we should typedef HANDLE FileDescriptor on Windows and then have
GetFileHandleForProcess return a FileDescriptor. This would eliminate the chance
of forgetting to close the handle on Posix, and also allow us to delete the
other ifdef in the database_message_filter function you changed.

Actually, looking at this more, what I've described is exactly
PlatformFileForTransit in src/ipc/ipc_platform_file.h. How about moving your
function there and returning a PlatformFileForTransit?

If we do this we should probably use the implementation from
ShareHandleWithRemote in
http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/proxy/proxy_channel.cc?...

[Jay Civelli, 2011/06/14 00:19:27]

OK, moved that method to ipc_plaform_file,cc and reusing the code from ppapi
procy_channel.cc.

+
 // Use this class to pass ownership of a PlatformFile to a receiver that may or
 // may not want to accept it.  This class does not own the storage for the
 // PlatformFile.