Fix to vertical alignment of titles on the settings/internet page.

Fix to vertical alignment of titles on the settings/internet page.


TEST=Compile Chrome for Chrome OS.  Load the setings/internet page, and check the vertical alignemnt of the section titles.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88667

[James Hawkins, 2011-06-09 16:45:52]

http://codereview.chromium.org/7044084/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options/chromeos/internet_options.html (right):

http://codereview.chromium.org/7044084/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/chromeos/internet_options.html:35: <h3
i18n-content="wired_title" class="topAlignTitle"></h3>
nit: Class names use dash-form.

[James Hawkins, 2011-06-09 17:02:19]

http://codereview.chromium.org/7044084/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options/chromeos/internet_options.html (right):

http://codereview.chromium.org/7044084/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/chromeos/internet_options.html:35: <h3
i18n-content="wired_title" class="topAlignTitle"></h3>
On 2011/06/09 16:45:52, James Hawkins wrote:
> nit: Class names use dash-form.

When you fix an issue described in a comment, can you please press the 'Done'
button for each comment when publishing? Otherwise it's difficult to know what
has changed.

http://codereview.chromium.org/7044084/diff/4002/chrome/browser/resources/opt...
File chrome/browser/resources/options/chromeos/internet_options_page.css
(right):

http://codereview.chromium.org/7044084/diff/4002/chrome/browser/resources/opt...
chrome/browser/resources/options/chromeos/internet_options_page.css:97:
.displaytable > section > .top-align-title {
nit: CSS classes should not have visual descriptors in their name, 'top-align'.
The name should describe the set of elements that the selector matches.

[kevers, 2011-06-09 20:54:15]

http://codereview.chromium.org/7044084/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options/chromeos/internet_options.html (right):

http://codereview.chromium.org/7044084/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/chromeos/internet_options.html:35: <h3
i18n-content="wired_title" class="topAlignTitle"></h3>
On 2011/06/09 16:45:52, James Hawkins wrote:
> nit: Class names use dash-form.

Done.

http://codereview.chromium.org/7044084/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/chromeos/internet_options.html:35: <h3
i18n-content="wired_title" class="topAlignTitle"></h3>
On 2011/06/09 17:02:19, James Hawkins wrote:
> On 2011/06/09 16:45:52, James Hawkins wrote:
> > nit: Class names use dash-form.
> 
> When you fix an issue described in a comment, can you please press the 'Done'
> button for each comment when publishing? Otherwise it's difficult to know what
> has changed.

Done.

http://codereview.chromium.org/7044084/diff/4002/chrome/browser/resources/opt...
File chrome/browser/resources/options/chromeos/internet_options_page.css
(right):

http://codereview.chromium.org/7044084/diff/4002/chrome/browser/resources/opt...
chrome/browser/resources/options/chromeos/internet_options_page.css:97:
.displaytable > section > .top-align-title {
On 2011/06/09 17:02:19, James Hawkins wrote:
> nit: CSS classes should not have visual descriptors in their name,
'top-align'.
> The name should describe the set of elements that the selector matches.

Done.

[James Hawkins, 2011-06-09 20:56:17]

LGTM, thanks.

[Rick Byers, 2011-06-10 02:52:44]

http://codereview.chromium.org/7044084/diff/1004/chrome/browser/resources/opt...
File chrome/browser/resources/options/chromeos/internet_options.html (right):

http://codereview.chromium.org/7044084/diff/1004/chrome/browser/resources/opt...
chrome/browser/resources/options/chromeos/internet_options.html:47: <section
id="remembered-section" class="network-title">
Did you mean to put this on a section instead of the h3 below?  The section
isn't really a "title", and your CSS rule won't apply to this...

[kevers, 2011-06-10 13:43:42]

http://codereview.chromium.org/7044084/diff/1004/chrome/browser/resources/opt...
File chrome/browser/resources/options/chromeos/internet_options.html (right):

http://codereview.chromium.org/7044084/diff/1004/chrome/browser/resources/opt...
chrome/browser/resources/options/chromeos/internet_options.html:47: <section
id="remembered-section" class="network-title">
On 2011/06/10 02:52:44, rbyers wrote:
> Did you mean to put this on a section instead of the h3 below?  The section
> isn't really a "title", and your CSS rule won't apply to this...

Fixed.

[Rick Byers, 2011-06-10 13:53:28]

LGTM

[commit-bot: I haz the power, 2011-06-10 15:28:38]

Change committed as 88667