Issue 7044081: Use the previous context link when checking context extension objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7044081: Use the previous context link when checking context extension objects. (Closed)

Created:
9 years, 6 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 6 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Use the previous context link when checking context extension objects. In generated code, when walking the context to inspect context extension objects, use the previous context link directly. R=ager@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=8248

Patch Set 1 #

Total comments: 1

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -35 lines)			Patch
M	src/arm/full-codegen-arm.cc	View	3 chunks	+3 lines, -6 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View	3 chunks	+3 lines, -6 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1 chunk	+1 line, -2 lines	1 comment	Download
M	src/mips/full-codegen-mips.cc	View	3 chunks	+3 lines, -6 lines	0 comments	Download
M	src/mips/macro-assembler-mips.cc	View	1 chunk	+2 lines, -5 lines	0 comments	Download
M	src/x64/full-codegen-x64.cc	View	3 chunks	+3 lines, -6 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

9 years, 6 months ago (2011-06-09 17:32:07 UTC) #2

LGTM

http://codereview.chromium.org/7044081/diff/1/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):

http://codereview.chromium.org/7044081/diff/1/src/ia32/lithium-codegen-ia32.c...
src/ia32/lithium-codegen-ia32.cc:2681: __ mov(result, Operand(context,
Context::SlotOffset(Context::PREVIOUS_INDEX)));
Long line?

Expand Messages | Collapse Messages