Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 7044074: Don't write image markup to the clipboard when copying images on OS X. (Closed)

Created:
9 years, 6 months ago by dcheng
Modified:
9 years, 6 months ago
Reviewers:
Nico
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Don't write image markup to the clipboard when copying images on OS X. If image markup is present on the clipboard, Mail.app will always prefer it over the actual image even if we declare the image types before the HTML type in -[NSPasteboard types]. With this change, we also match the behavior of other Mac browser when invoking the "Copy Image" action. BUG=33016 TEST=Manual test with 'copy image' context menu item and then pasting it into a Mail.app draft. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88569

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M webkit/glue/webclipboard_impl.cc View 1 chunk +8 lines, -4 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
dcheng
9 years, 6 months ago (2011-06-09 05:36:39 UTC) #1
Nico
9 years, 6 months ago (2011-06-09 16:11:38 UTC) #2
LGTM

http://codereview.chromium.org/7044074/diff/1/webkit/glue/webclipboard_impl.cc
File webkit/glue/webclipboard_impl.cc (right):

http://codereview.chromium.org/7044074/diff/1/webkit/glue/webclipboard_impl.c...
webkit/glue/webclipboard_impl.cc:190: // the image markup over attaching the
actual image.
nit: Maybe add "See http://crbug.com/33016"

Powered by Google App Engine
This is Rietveld 408576698