Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 7044071: Rewrite BrowserTest.PageLanguageDetection to use a new tab instead of the one with about:blank. (Closed)

Created:
9 years, 6 months ago by Yoyo Zhou
Modified:
9 years, 6 months ago
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, brettw-cc_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Rewrite BrowserTest.PageLanguageDetection to use a new tab instead of the one with about:blank. Revert "Revert 88068 (Mac 10.5 bots are failing) - No longer require nonzero content to send it to the translate helper. In practice this makes an empty page's language be detected as "und" instead of failing to be detected." This reverts commit 3ca079900c491836610c9452f9894bb5bdebdeac. Conflicts: chrome/test/data/extensions/api_test/tabs/basics/crud.html BUG=60802 TEST=ExtensionApiTest.Tabs detectLanguage, and BrowserTest.PageLanguageDetection Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88567

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M chrome/browser/browser_browsertest.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M chrome/renderer/chrome_render_view_observer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/tabs/basics/crud.html View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Yoyo Zhou
9 years, 6 months ago (2011-06-08 23:46:46 UTC) #1
Jay Civelli
LGTM
9 years, 6 months ago (2011-06-09 16:02:43 UTC) #2
commit-bot: I haz the power
Try job failure for 7044071-1 on win for step compile: http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=36089
9 years, 6 months ago (2011-06-09 16:41:14 UTC) #3
commit-bot: I haz the power
Try job failure for 7044071-1 on mac for step media_unittests: http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number=31366
9 years, 6 months ago (2011-06-09 17:15:07 UTC) #4
commit-bot: I haz the power
Try job failure for 7044071-1 on linux for step update_scripts: http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux&number=31256
9 years, 6 months ago (2011-06-09 18:01:32 UTC) #5
commit-bot: I haz the power
9 years, 6 months ago (2011-06-09 19:18:55 UTC) #6
Change committed as 88567

Powered by Google App Engine
This is Rietveld 408576698