Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1553)

Unified Diff: chrome/browser/printing/print_dialog_cloud.cc

Issue 7044070: Fix to allow print job submission in Linux (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Minor Style changes Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/printing/print_dialog_cloud.cc
diff --git a/chrome/browser/printing/print_dialog_cloud.cc b/chrome/browser/printing/print_dialog_cloud.cc
index 6cb19322f8bf2e607fcd6d4b7a0366678e433f04..3b0aca640e9acce1c4028a49cd1aa0268b064326 100644
--- a/chrome/browser/printing/print_dialog_cloud.cc
+++ b/chrome/browser/printing/print_dialog_cloud.cc
@@ -9,6 +9,7 @@
#include "base/command_line.h"
#include "base/file_util.h"
#include "base/json/json_reader.h"
+#include "base/utf_string_conversions.h"
#include "base/values.h"
#include "chrome/browser/debugger/devtools_manager.h"
#include "chrome/browser/prefs/pref_service.h"
@@ -604,8 +605,12 @@ bool CreatePrintDialogFromCommandLine(const CommandLine& command_line) {
switches::kCloudPrintJobTitle);
print_job_title = string16(native_job_title);
#elif defined(OS_POSIX)
- // TODO(abodenha@chromium.org) Implement this for OS_POSIX
- // Command line string types are different
+ // POSIX Command line string types are different.
+ CommandLine::StringType native_job_title;
+ native_job_title = command_line.GetSwitchValueASCII(
+ switches::kCloudPrintJobTitle);
+ // Convert the ASCII string to UTF16 to prepare to pass.
+ print_job_title = string16(ASCIIToUTF16(native_job_title));
#endif
}
std::string file_type = "application/pdf";
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698