Use SkMatrix44 for the underlying implementation of ui::Transform

views/view_unittest.cc

Index: views/view_unittest.cc
diff --git a/views/view_unittest.cc b/views/view_unittest.cc
index 4052eb68a8b9c84930f73dbc5a09bd18edbab08c..4d82d10c8aaa4ecc9c7beef277ef1a3d0bfd0780 100644
--- a/views/view_unittest.cc
+++ b/views/view_unittest.cc
@@ -633,6 +633,18 @@ gfx::Point ConvertPointToView(View* view, const gfx::Point& p) {
   return tmp;
 }
 
+void RotateCounterclockwise(ui::Transform& transform) {
+  transform.matrix().set3x3(0, -1, 0,
+                            1,  0, 0,
+                            0,  0, 1);
+}
+
+void RotateClockwise(ui::Transform& transform) {
+  transform.matrix().set3x3( 0, 1, 0,
+                            -1, 0, 0,
+                             0, 0, 1);
+}
+
 }  // namespace
 
 TEST_F(ViewTest, HitTestMasks) {
@@ -1541,7 +1553,7 @@ TEST_F(ViewTest, TransformPaint) {
 
   // Rotate |v1| counter-clockwise.
   ui::Transform transform;
-  transform.SetRotate(-90.0f);
+  RotateCounterclockwise(transform);
   transform.SetTranslateY(500.0f);
   v1->SetTransform(transform);
 
@@ -1575,7 +1587,7 @@ TEST_F(ViewTest, TransformEvent) {
 
   // Rotate |v1| counter-clockwise.
   ui::Transform transform(v1->GetTransform());
-  transform.SetRotate(-90.0f);
+  RotateCounterclockwise(transform);
   transform.SetTranslateY(500.0f);
   v1->SetTransform(transform);
 
@@ -1597,7 +1609,7 @@ TEST_F(ViewTest, TransformEvent) {
 
   // Now rotate |v2| inside |v1| clockwise.
   transform = v2->GetTransform();
-  transform.SetRotate(90.0f);
+  RotateClockwise(transform);
   transform.SetTranslateX(100.0f);
   v2->SetTransform(transform);
 
@@ -1627,7 +1639,7 @@ TEST_F(ViewTest, TransformEvent) {
 
   // Rotate |v3| clockwise with respect to |v2|.
   transform = v1->GetTransform();
-  transform.SetRotate(90.0f);
+  RotateClockwise(transform);
   transform.SetTranslateX(30.0f);
   v3->SetTransform(transform);
 
@@ -1663,7 +1675,7 @@ TEST_F(ViewTest, TransformEvent) {
 
   // Rotate |v3| clockwise with respect to |v2|, and scale it along both axis.
   transform = v3->GetTransform();
-  transform.SetRotate(90.0f);
+  RotateClockwise(transform);
   transform.SetTranslateX(30.0f);
   // Rotation sets some scaling transformation. Using SetScale would overwrite
   // that and pollute the rotation. So combine the scaling with the existing
@@ -1716,7 +1728,7 @@ TEST_F(ViewTest, TransformVisibleBound) {
 
   // Rotate |child| counter-clockwise
   ui::Transform transform;
-  transform.SetRotate(-90.0f);
+  RotateCounterclockwise(transform);
   transform.SetTranslateY(50.0f);
   child->SetTransform(transform);
   EXPECT_EQ(gfx::Rect(40, 0, 10, 50), child->GetVisibleBounds());
@@ -1847,12 +1859,15 @@ TEST_F(ViewTest, ConvertPointToViewWithTransform) {
     transform.ConcatScale(100, 55);
     transform.ConcatTranslate(110, -110);
 
-    EXPECT_EQ(210, transform.matrix().getTranslateX());
-    EXPECT_EQ(-55, transform.matrix().getTranslateY());
-    EXPECT_EQ(100, transform.matrix().getScaleX());
-    EXPECT_EQ(55, transform.matrix().getScaleY());
-    EXPECT_EQ(0, transform.matrix().getSkewX());
-    EXPECT_EQ(0, transform.matrix().getSkewY());
+    // convert to a 3x3 matrix.
+    SkMatrix matrix = transform.matrix();

[sky, 2011/06/24 20:58:19]

const SkMatrix& here and other places.

+
+    EXPECT_EQ(210, matrix.getTranslateX());
+    EXPECT_EQ(-55, matrix.getTranslateY());
+    EXPECT_EQ(100, matrix.getScaleX());
+    EXPECT_EQ(55, matrix.getScaleY());
+    EXPECT_EQ(0, matrix.getSkewX());
+    EXPECT_EQ(0, matrix.getSkewY());
   }
 
   {
@@ -1865,12 +1880,15 @@ TEST_F(ViewTest, ConvertPointToViewWithTransform) {
     transform.ConcatTransform(t2);
     transform.ConcatTransform(t3);
 
-    EXPECT_EQ(210, transform.matrix().getTranslateX());
-    EXPECT_EQ(-55, transform.matrix().getTranslateY());
-    EXPECT_EQ(100, transform.matrix().getScaleX());
-    EXPECT_EQ(55, transform.matrix().getScaleY());
-    EXPECT_EQ(0, transform.matrix().getSkewX());
-    EXPECT_EQ(0, transform.matrix().getSkewY());
+    // convert to a 3x3 matrix
+    SkMatrix matrix = transform.matrix();
+
+    EXPECT_EQ(210, matrix.getTranslateX());
+    EXPECT_EQ(-55, matrix.getTranslateY());
+    EXPECT_EQ(100, matrix.getScaleX());
+    EXPECT_EQ(55, matrix.getScaleY());
+    EXPECT_EQ(0, matrix.getSkewX());
+    EXPECT_EQ(0, matrix.getSkewY());
   }
 
   // Conversions from child->top and top->child.