Fix Array.prototype.{reduce,reduceRight} to pass undefined as receiver

test/mjsunit/regress/regress-1436.js

-// Copyright 2010 the V8 project authors. All rights reserved.
+// Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
 //       with the distribution.
 //     * Neither the name of Google Inc. nor the names of its
 //       contributors may be used to endorse or promote products derived
 //       from this software without specific prior written permission.
 //
 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-#ifndef V8_PREPARSE_DATA_FORMAT_H_
-#define V8_PREPARSE_DATA_FORMAT_H_
+// Check that reduce and reduceRight call the callback function with
+// undefined as the receiver (which for non-strict functions is
+// transformed to the global object).
 
-namespace v8 {
-namespace internal {
+// Check receiver for reduce and reduceRight.
 
-// Generic and general data used by preparse data recorders and readers.
+var global = this;
+function non_strict(){ assertEquals(global, this); }
+function strict(){ "use strict"; assertEquals(void 0, this); }
 
-struct PreparseDataConstants {
- public:
-  // Layout and constants of the preparse data exchange format.
-  static const unsigned kMagicNumber = 0xBadDead;
-  static const unsigned kCurrentVersion = 6;
-
-  static const int kMagicOffset = 0;
-  static const int kVersionOffset = 1;
-  static const int kHasErrorOffset = 2;
-  static const int kFunctionsSizeOffset = 3;
-  static const int kSymbolCountOffset = 4;
-  static const int kSizeOffset = 5;
-  static const int kHeaderSize = 6;
-
-  // If encoding a message, the following positions are fixed.
-  static const int kMessageStartPos = 0;
-  static const int kMessageEndPos = 1;
-  static const int kMessageArgCountPos = 2;
-  static const int kMessageTextPos = 3;
-
-  static const unsigned char kNumberTerminator = 0x80u;
-};
+[2, 3].reduce(non_strict);
+[2, 3].reduceRight(non_strict);
+[2, 3].reduce(strict);

[Lasse Reichstein, 2011/06/09 08:57:02]

Group by function called, like below (i.e., both reduce calls before the
reduceRight calls).

[Mads Ager (chromium), 2011/06/09 09:05:03]

Done.

+[2, 3].reduceRight(strict);
 
 
-} }  // namespace v8::internal.
-
-#endif  // V8_PREPARSE_DATA_FORMAT_H_
+// Check the receiver for callbacks in other array methods.
+[2, 3].filter(non_strict);
+[2, 3].filter(strict);
+[2, 3].forEach(non_strict);
+[2, 3].forEach(strict);
+[2, 3].some(non_strict);
+[2, 3].some(strict);
+[2, 3].every(non_strict);
+[2, 3].every(strict);
+[2, 3].map(non_strict);
+[2, 3].map(strict);

[Lasse Reichstein, 2011/06/09 08:57:02]

How about putting them in alphabetic order.
Matbe also call with explicit thisArg values, both undefined and null (the
strict mode function would need to be different for the null call).

[Mads Ager (chromium), 2011/06/09 09:05:03]

Done.