src/hydrogen-instructions.cc - Issue 7044049: Add boolean flag to HChange and LNumberUntagD to not convert undefined to NaN.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen-instructions.cc

Issue 7044049: Add boolean flag to HChange and LNumberUntagD to not convert undefined to NaN. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Add regression test, change test status. Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/hydrogen-instructions.cc

diff --git a/src/hydrogen-instructions.cc b/src/hydrogen-instructions.cc

index cc2dcf5c788560cb0f82788cdabd7d76573a8119..110d8e4c9356b778bfb660dc0bd411fe65d42e87 100644

--- a/src/hydrogen-instructions.cc

+++ b/src/hydrogen-instructions.cc

@@ -1240,6 +1240,10 @@ void HCompare::SetInputRepresentation(Representation r) {

if (r.IsTagged()) {

SetAllSideEffects();

ClearFlag(kUseGVN);

+ } else if (r.IsDouble()) {

+ SetFlag(kDeoptimizeOnUndefined);

+ ClearAllSideEffects();

+ SetFlag(kUseGVN);

} else {

ClearAllSideEffects();

SetFlag(kUseGVN);

« src/arm/lithium-arm.h ('K') | « src/hydrogen-instructions.h ('k') | src/ia32/lithium-codegen-ia32.h » ('j') | no next file with comments »