Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/arm/lithium-arm.h

Issue 7044049: Add boolean flag to HChange and LNumberUntagD to not convert undefined to NaN. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Add regression test, change test status. Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/arm/lithium-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1638 matching lines...) Expand 10 before | Expand all | Expand 10 after
1649 explicit LSmiTag(LOperand* value) { 1649 explicit LSmiTag(LOperand* value) {
1650 inputs_[0] = value; 1650 inputs_[0] = value;
1651 } 1651 }
1652 1652
1653 DECLARE_CONCRETE_INSTRUCTION(SmiTag, "smi-tag") 1653 DECLARE_CONCRETE_INSTRUCTION(SmiTag, "smi-tag")
1654 }; 1654 };
1655 1655
1656 1656
1657 class LNumberUntagD: public LTemplateInstruction<1, 1, 0> { 1657 class LNumberUntagD: public LTemplateInstruction<1, 1, 0> {
1658 public: 1658 public:
1659 explicit LNumberUntagD(LOperand* value) { 1659 LNumberUntagD(LOperand* value, bool deoptimize_on_undefined)
1660 : deoptimize_on_undefined_(deoptimize_on_undefined) {
1660 inputs_[0] = value; 1661 inputs_[0] = value;
1661 } 1662 }
1662 1663
1664 bool deoptimize_on_undefined() { return deoptimize_on_undefined_; }
fschneider 2011/06/09 10:57:22 I think you can change this to { return hydrogen(
1665
1663 DECLARE_CONCRETE_INSTRUCTION(NumberUntagD, "double-untag") 1666 DECLARE_CONCRETE_INSTRUCTION(NumberUntagD, "double-untag")
fschneider 2011/06/09 10:57:22 Add DECLARE_HYDROGEN_ACCESSOR(Change) here. The s
William Hesse 2011/06/09 12:26:32 Done.
1667
1668 private:
1669 bool deoptimize_on_undefined_;
1664 }; 1670 };
1665 1671
1666 1672
1667 class LSmiUntag: public LTemplateInstruction<1, 1, 0> { 1673 class LSmiUntag: public LTemplateInstruction<1, 1, 0> {
1668 public: 1674 public:
1669 LSmiUntag(LOperand* value, bool needs_check) 1675 LSmiUntag(LOperand* value, bool needs_check)
1670 : needs_check_(needs_check) { 1676 : needs_check_(needs_check) {
1671 inputs_[0] = value; 1677 inputs_[0] = value;
1672 } 1678 }
1673 1679
(...skipping 644 matching lines...) Expand 10 before | Expand all | Expand 10 after
2318 2324
2319 DISALLOW_COPY_AND_ASSIGN(LChunkBuilder); 2325 DISALLOW_COPY_AND_ASSIGN(LChunkBuilder);
2320 }; 2326 };
2321 2327
2322 #undef DECLARE_HYDROGEN_ACCESSOR 2328 #undef DECLARE_HYDROGEN_ACCESSOR
2323 #undef DECLARE_CONCRETE_INSTRUCTION 2329 #undef DECLARE_CONCRETE_INSTRUCTION
2324 2330
2325 } } // namespace v8::internal 2331 } } // namespace v8::internal
2326 2332
2327 #endif // V8_ARM_LITHIUM_ARM_H_ 2333 #endif // V8_ARM_LITHIUM_ARM_H_
OLDNEW
« no previous file with comments | « no previous file | src/arm/lithium-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698