Issue 7044049: Add boolean flag to HChange and LNumberUntagD to not convert undefined to NaN.

Issue 7044049: Add boolean flag to HChange and LNumberUntagD to not convert undefined to NaN. (Closed)

Created:
9 years, 6 months ago by William Hesse

Modified:
9 years, 6 months ago

Reviewers:
fschneider

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Add boolean flag to HChange and LNumberUntagD to not convert undefined to NaN. This is needed so that HCompare, optimized for double inputs, works correctly on undefined inputs. BUG=v8:1434 TEST=mjsunit/bugs/bug-1434.js Committed: http://code.google.com/p/v8/source/detail?r=8237

Patch Set 1 #

Total comments: 3

Patch Set 2 : fix typography #

Patch Set 3 : Add regression test, change test status. #

Total comments: 3

Patch Set 4 : Incorporate cl comments. #

Patch Set 5 : fix typo #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+123 lines, -78 lines)			Patch
M	src/arm/lithium-arm.h	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	1 2 3	3 chunks	+19 lines, -11 lines	0 comments	Download
M	src/hydrogen.h	View	1 2 3	2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/hydrogen.cc	View	1 2 3	4 chunks	+39 lines, -2 lines	0 comments	Download
M	src/hydrogen-instructions.h	View	1 2 3	4 chunks	+10 lines, -3 lines	0 comments	Download
M	src/hydrogen-instructions.cc	View	1 2 3	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.h	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1 2 3	3 chunks	+18 lines, -10 lines	0 comments	Download
M	src/ia32/lithium-ia32.h	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.h	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1 2 3	3 chunks	+18 lines, -10 lines	0 comments	Download
M	src/x64/lithium-x64.h	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
D	test/mjsunit/bugs/bug-1434.js	View	1 2	1 chunk	+0 lines, -36 lines	0 comments	Download
M	test/mjsunit/mjsunit.status	View	1 2	1 chunk	+0 lines, -3 lines	0 comments	Download
A +	test/mjsunit/regress/regress-1434.js	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

William Hesse

http://codereview.chromium.org/7044049/diff/1/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): http://codereview.chromium.org/7044049/diff/1/src/hydrogen-instructions.h#newcode2512 src/hydrogen-instructions.h:2512: Removed. http://codereview.chromium.org/7044049/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): http://codereview.chromium.org/7044049/diff/1/src/hydrogen.cc#newcode1864 src/hydrogen.cc:1864: Removed. http://codereview.chromium.org/7044049/diff/1/src/hydrogen.cc#newcode1867 ...

9 years, 6 months ago (2011-06-08 14:30:30 UTC) #1

fschneider

LGTM. http://codereview.chromium.org/7044049/diff/1017/src/arm/lithium-arm.h File src/arm/lithium-arm.h (right): http://codereview.chromium.org/7044049/diff/1017/src/arm/lithium-arm.h#newcode1664 src/arm/lithium-arm.h:1664: bool deoptimize_on_undefined() { return deoptimize_on_undefined_; } I think ...

9 years, 6 months ago (2011-06-09 10:57:22 UTC) #2

William Hesse

9 years, 6 months ago (2011-06-09 12:26:32 UTC) #3

http://codereview.chromium.org/7044049/diff/1017/src/arm/lithium-arm.h
File src/arm/lithium-arm.h (right):

http://codereview.chromium.org/7044049/diff/1017/src/arm/lithium-arm.h#newcod...
src/arm/lithium-arm.h:1666: DECLARE_CONCRETE_INSTRUCTION(NumberUntagD,
"double-untag")
On 2011/06/09 10:57:22, fschneider wrote:
> Add DECLARE_HYDROGEN_ACCESSOR(Change) here.
> 
> The same applies for the other platforms as well.

Done.

Expand Messages | Collapse Messages