Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 7044048: GTTF: Initialize TestTimeouts in out-of-process test runner. (Closed)

Created:
9 years, 6 months ago by Paweł Hajdan Jr.
Modified:
9 years, 6 months ago
Reviewers:
Mark Mentovai, brettw, sky
CC:
chromium-reviews, brettw-cc_chromium.org, Paweł Hajdan Jr., Raghu Simha
Visibility:
Public.

Description

GTTF: Initialize TestTimeouts in out-of-process test runner. This is needed to make command-line changes take effect. Also, added checks to prevent a similar mistake from happening in the future. Actually, the checks detected such misuse in process_util_unittests, and this CL fixes it. BUG=85287 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88561

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -11 lines) Patch
M base/process_util_unittest.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M base/test/test_timeouts.h View 2 chunks +22 lines, -5 lines 0 comments Download
M chrome/test/out_of_proc_test_runner.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Paweł Hajdan Jr.
Please review: Brett: entire CL Scott: chrome/test, of course feel free to take a look ...
9 years, 6 months ago (2011-06-08 13:25:07 UTC) #1
sky
LGTM
9 years, 6 months ago (2011-06-08 16:07:05 UTC) #2
sky
Pawel, I believe Brett is on vacation all week. -Scott
9 years, 6 months ago (2011-06-08 18:06:56 UTC) #3
Paweł Hajdan Jr.
Mark, could you take a look at changes in base/ ? I'm mostly concerned about ...
9 years, 6 months ago (2011-06-08 18:57:08 UTC) #4
Mark Mentovai
9 years, 6 months ago (2011-06-09 14:43:57 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698