Issue 7044043: Update expected version# of a plugin on chromeos

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7044043: Update expected version# of a plugin on chromeos (Closed)

Created:
9 years, 6 months ago by Nirnimesh

Modified:
9 years, 6 months ago

Reviewers:
krisr

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Update expected version# of a plugin on chromeos R=krisr@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88289

Patch Set 1 #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/test/data/chromeos_plugins_list.txt	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

krisr

9 years, 6 months ago (2011-06-08 05:34:53 UTC) #2

LGTM

On Tue, Jun 7, 2011 at 10:33 PM, <nirnimesh@chromium.org> wrote:

> Reviewers: krisr,
>
> Description:
> Update expected version# of a plugin on chromeos
>
>
> R=krisr@chromium.org
> BUG=
> TEST=
>
>
> Please review this at http://codereview.chromium.org/7044043/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M chrome/test/data/chromeos_plugins_list.txt
>
>
> Index: chrome/test/data/chromeos_plugins_list.txt
> diff --git a/chrome/test/data/chromeos_plugins_list.txt
> b/chrome/test/data/chromeos_plugins_list.txt
> index
>
87b6f8e562d6c678f49bcfda6a89ab4b64a7aef7..557b63a1eb4c352264cee48351f1ea43b34fee4c
> 100644
> --- a/chrome/test/data/chromeos_plugins_list.txt
> +++ b/chrome/test/data/chromeos_plugins_list.txt
> @@ -8,7 +8,7 @@
>  {u'unique_key':'path', u'name':u'Shockwave Flash',
> u'path':'/opt/google/chrome/pepper/libpepflashplayer.so', u'enabled':1,
> u'boards':['x86-mario', 'x86-alex', 'x86-zgb']},
>  {u'unique_key':'path', u'name':u'Shockwave Flash',
> u'path':'/opt/google/chrome/plugins/libgcflashplayer.so', u'enabled':1,
> u'boards':['x86-mario', 'x86-alex', 'x86-zgb']},
>  {u'name':'Chrome PDF Viewer', u'enabled':1, u'version':u'',
> u'boards':['x86-mario', 'x86-alex', 'x86-zgb']},
> - {u'name':'Netflix', u'enabled':1, u'version':u'0.4.3',
> u'boards':['x86-alex', 'x86-zgb']},
> + {u'name':'Netflix', u'enabled':1, u'version':u'0.5.0',
> u'boards':['x86-alex', 'x86-zgb']},
>  {u'name':'Google Talk Plugin', u'enabled':1, u'version':u'',
> u'boards':['x86-mario', 'x86-alex', 'x86-zgb']},
>  {u'name':'O3D Plugin', u'enabled':1, u'version':u'',
> u'boards':['x86-mario', 'x86-alex', 'x86-zgb']},
>  {u'name':'Default Plug-in', u'enabled':1, u'version':u'1',
> u'boards':['x86-mario', 'x86-alex', 'x86-zgb']},
>
>
>

Expand Messages | Collapse Messages