Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: chrome/renderer/autofill/form_manager_browsertest.cc

Issue 7044032: Heuristics for grabber-google.com.out (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/autofill/form_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/autofill/form_manager_browsertest.cc
diff --git a/chrome/renderer/autofill/form_manager_browsertest.cc b/chrome/renderer/autofill/form_manager_browsertest.cc
index 82ae004433a11bb8548d2281b1c4cd19a69b3702..a6f69a81f1b48fd236da834d8ebbe79cf5582327 100644
--- a/chrome/renderer/autofill/form_manager_browsertest.cc
+++ b/chrome/renderer/autofill/form_manager_browsertest.cc
@@ -1273,9 +1273,10 @@ TEST_F(FormManagerTest, LabelsInferredFromTableEmptyTDs) {
labels, names, values);
}
-// <script> and <option> tags are excluded when the labels are inferred.
+// <script>, <noscript> and <option> tags are excluded when the labels are
+// inferred.
// Also <!-- comment --> is excluded.
-TEST_F(FormManagerTest, LabelsInferredFromTableWithScriptOptionTagAndComment) {
+TEST_F(FormManagerTest, LabelsInferredFromTableWithSpecialElements) {
std::vector<string16> labels, names, values, control_types;
labels.push_back(ASCIIToUTF16("*First Name"));
@@ -1283,6 +1284,11 @@ TEST_F(FormManagerTest, LabelsInferredFromTableWithScriptOptionTagAndComment) {
values.push_back(ASCIIToUTF16("John"));
control_types.push_back(ASCIIToUTF16("text"));
+ labels.push_back(ASCIIToUTF16("*Middle Name"));
+ names.push_back(ASCIIToUTF16("middlename"));
+ values.push_back(ASCIIToUTF16("Joe"));
+ control_types.push_back(ASCIIToUTF16("text"));
+
labels.push_back(ASCIIToUTF16("*Last Name"));
names.push_back(ASCIIToUTF16("lastname"));
values.push_back(ASCIIToUTF16("Smith"));
@@ -1315,6 +1321,18 @@ TEST_F(FormManagerTest, LabelsInferredFromTableWithScriptOptionTagAndComment) {
" <TR>"
" <TD>"
" <SPAN>*</SPAN>"
+ " <B>Middle Name</B>"
+ " </TD>"
+ " <TD>"
+ " <NOSCRIPT>"
+ " <P>Bad</P>"
+ " </NOSCRIPT>"
+ " <INPUT type=\"text\" id=\"middlename\" value=\"Joe\"/>"
+ " </TD>"
+ " </TR>"
+ " <TR>"
+ " <TD>"
+ " <SPAN>*</SPAN>"
" <B>Last Name</B>"
" </TD>"
" <TD>"
« no previous file with comments | « chrome/renderer/autofill/form_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698