Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 7044030: Include crypto_unittests in the flakiness dashboard (Closed)

Created:
9 years, 7 months ago by Ryan Sleevi
Modified:
9 years, 7 months ago
Reviewers:
tony
CC:
chromium-reviews, rvargas (doing something else)
Visibility:
Public.

Description

Include crypto_unittests in the flakiness dashboard BUG=83184 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86041

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M dashboard_base.js View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ryan Sleevi
PTAL
9 years, 7 months ago (2011-05-19 05:29:11 UTC) #1
Ryan Sleevi
+cc rvargas
9 years, 7 months ago (2011-05-19 08:34:21 UTC) #2
tony
LGTM
9 years, 7 months ago (2011-05-19 16:36:39 UTC) #3
tony
9 years, 7 months ago (2011-05-19 16:36:54 UTC) #4
Oops, forgot to hit publish.  Still LGTM

http://codereview.chromium.org/7044030/diff/1/dashboard_base.js
File dashboard_base.js (right):

http://codereview.chromium.org/7044030/diff/1/dashboard_base.js#newcode100
dashboard_base.js:100: 'crypto_unittests', 'courgette_unittests',
'googleurl_unittests',
Nit: alphabetize (crypto comes after courgette)

http://codereview.chromium.org/7044030/diff/1/dashboard_base.js#newcode392
dashboard_base.js:392: case 'crypto_unittests':
Nit: alphabetize

Powered by Google App Engine
This is Rietveld 408576698