Issue 7044029: Valgrind: Add crypto_unittests to the memory tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7044029: Valgrind: Add crypto_unittests to the memory tests. (Closed)

Created:
9 years, 7 months ago by rvargas (doing something else)

Modified:
9 years, 6 months ago

Reviewers:
Timur Iskhodzhanov, Ryan Sleevi

CC:
chromium-reviews, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Valgrind: Add crypto_unittests to the memory tests. BUG=none TEST=none

Total comments: 1

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	tools/valgrind/chrome_tests.py	View		2 chunks	+4 lines, -0 lines	1 comment	Download

Total messages: 6 (0 generated)

rvargas (doing something else)

I'm not really sure what I'm doing :)

9 years, 7 months ago (2011-05-19 01:43:13 UTC) #1

Ryan Sleevi

rvargas: Sorry, I missed this when looking to see if you'd started it yet. Just ...

9 years, 7 months ago (2011-05-19 08:39:04 UTC) #2

Timur Iskhodzhanov

Am I right that a) crypto tests were splitted from base_ b) all the tests ...

9 years, 7 months ago (2011-05-19 16:41:31 UTC) #3

Timur Iskhodzhanov

Please make sure everything runs correct by invoking ./tools/valgrind/chrome_tests.sh -t crypto

9 years, 7 months ago (2011-05-19 16:41:58 UTC) #4

Timur Iskhodzhanov

And add the same patch to ./tools/heapcheck/chrome_tests.py ?

9 years, 7 months ago (2011-05-19 16:43:00 UTC) #5

rvargas (doing something else)

9 years, 7 months ago (2011-05-19 21:27:25 UTC) #6

Thanks for the review.

Ryan: I'll let you do this then.