Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: views/controls/menu/menu_model_adapter_unittest.cc

Issue 7044016: Replace ButtonDropDown menu implementation (Menu2) with MenuItemView. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: One last little style fix. Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « views/controls/menu/menu_model_adapter.cc ('k') | views/view_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: views/controls/menu/menu_model_adapter_unittest.cc
diff --git a/views/controls/menu/menu_model_adapter_unittest.cc b/views/controls/menu/menu_model_adapter_unittest.cc
index dba68c80f1bed0e481a5e1394caa42cb6b89830e..035ec165a89224e7fa32a544a8801a45ab30604d 100644
--- a/views/controls/menu/menu_model_adapter_unittest.cc
+++ b/views/controls/menu/menu_model_adapter_unittest.cc
@@ -293,6 +293,11 @@ TEST_F(MenuModelAdapterTest, BasicTest) {
EXPECT_EQ(i + kFirstItemIndex, submodel->last_activation());
submodel->set_last_activation(-1);
}
+
+ // Check that selecting the root item is safe. The MenuModel does
+ // not care about the root so MenuModelAdapter should do nothing
+ // (not hit the NOTREACHED check) when the root is selected.
+ static_cast<views::MenuDelegate*>(&delegate)->SelectionChanged(menu.get());
}
} // namespace views
« no previous file with comments | « views/controls/menu/menu_model_adapter.cc ('k') | views/view_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698