Replace ButtonDropDown menu implementation (Menu2) with MenuItemView.

views/controls/button/button_dropdown.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "views/controls/button/button_dropdown.h"
 
 #include "base/compiler_specific.h"
 #include "base/message_loop.h"
 #include "base/utf_string_conversions.h"
 #include "grit/app_strings.h"
 #include "ui/base/accessibility/accessible_view_state.h"
 #include "ui/base/l10n/l10n_util.h"
-#include "views/controls/menu/view_menu_delegate.h"
+#include "ui/base/models/menu_model.h"
+#include "views/controls/menu/menu_item_view.h"
+#include "views/controls/menu/menu_model_adapter.h"
 #include "views/widget/widget.h"
+#include "views/window/window.h"
 
 namespace views {
 
 // How long to wait before showing the menu
 static const int kMenuTimerDelay = 500;
 
 ////////////////////////////////////////////////////////////////////////////////
 //
 // ButtonDropDown - constructors, destructors, initialization, cleanup
 //
@@ skipping 86 matching lines @@
 }
 
 bool ButtonDropDown::ShouldEnterPushedState(const MouseEvent& event) {
   // Enter PUSHED state on press with Left or Right mouse button. Remain
   // in this state while the context menu is open.
   return ((ui::EF_LEFT_BUTTON_DOWN |
       ui::EF_RIGHT_BUTTON_DOWN) & event.flags()) != 0;
 }
 
 void ButtonDropDown::ShowDropDownMenu(gfx::NativeView window) {
-  if (model_) {
-    gfx::Rect lb = GetLocalBounds();
+  gfx::Rect lb = GetLocalBounds();
 
-    // Both the menu position and the menu anchor type change if the UI layout
-    // is right-to-left.
-    gfx::Point menu_position(lb.origin());
-    menu_position.Offset(0, lb.height() - 1);
-    if (base::i18n::IsRTL())
-      menu_position.Offset(lb.width() - 1, 0);
+  // Both the menu position and the menu anchor type change if the UI layout
+  // is right-to-left.
+  gfx::Point menu_position(lb.origin());
+  menu_position.Offset(0, lb.height() - 1);
+  if (base::i18n::IsRTL())
+    menu_position.Offset(lb.width() - 1, 0);
 
-    View::ConvertPointToScreen(this, &menu_position);
+  View::ConvertPointToScreen(this, &menu_position);
 
 #if defined(OS_WIN)
-    int left_bound = GetSystemMetrics(SM_XVIRTUALSCREEN);
+  int left_bound = GetSystemMetrics(SM_XVIRTUALSCREEN);
 #else
-    int left_bound = 0;
-    NOTIMPLEMENTED();
+  int left_bound = 0;
+  NOTIMPLEMENTED();
 #endif
-    if (menu_position.x() < left_bound)
-      menu_position.set_x(left_bound);
+  if (menu_position.x() < left_bound)
+    menu_position.set_x(left_bound);
 
-    // Make the button look depressed while the menu is open.
-    SetState(BS_PUSHED);
-    menu_.reset(new Menu2(model_));
-    menu_->RunMenuAt(menu_position, Menu2::ALIGN_TOPLEFT);
+  // Make the button look depressed while the menu is open.
+  SetState(BS_PUSHED);
 
-    // Need to explicitly clear mouse handler so that events get sent
-    // properly after the menu finishes running. If we don't do this, then
-    // the first click to other parts of the UI is eaten.
-    SetMouseHandler(NULL);
+  // Create and run menu.  Display an empty menu if model is NULL.
+  if (model_) {
+    MenuModelAdapter menu_delegate(model_);
+    MenuItemView menu(&menu_delegate);
+    menu_delegate.BuildMenu(&menu);
 
-    // Set the state back to normal after the drop down menu is closed.
-    if (state_ != BS_DISABLED)
-      SetState(BS_NORMAL);
+    menu.RunMenuAt(GetWindow()->GetNativeWindow(), NULL,
+                   gfx::Rect(menu_position, gfx::Size(0, 0)),
+                   views::MenuItemView::TOPLEFT,
+                   true);
+  } else {
+    MenuDelegate menu_delegate;
+    MenuItemView menu(&menu_delegate);
+    menu.RunMenuAt(GetWindow()->GetNativeWindow(), NULL,
+                   gfx::Rect(menu_position, gfx::Size(0, 0)),
+                   views::MenuItemView::TOPLEFT,
+                   true);
   }
+
+  // Need to explicitly clear mouse handler so that events get sent
+  // properly after the menu finishes running. If we don't do this, then
+  // the first click to other parts of the UI is eaten.
+  SetMouseHandler(NULL);
+
+  // Set the state back to normal after the drop down menu is closed.
+  if (state_ != BS_DISABLED)
+    SetState(BS_NORMAL);
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 //
 // ButtonDropDown - Accessibility
 //
 ////////////////////////////////////////////////////////////////////////////////
 
 }  // namespace views