Drop url_constants dependency in content/.

content/browser/site_instance_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/stl_util-inl.h"
 #include "base/string16.h"
 #include "chrome/common/chrome_constants.h"
 #include "chrome/common/render_messages.h"
-#include "chrome/common/url_constants.h"
 #include "chrome/test/testing_profile.h"
 #include "content/browser/browser_thread.h"
 #include "content/browser/browsing_instance.h"
 #include "content/browser/child_process_security_policy.h"
 #include "content/browser/content_browser_client.h"
 #include "content/browser/renderer_host/browser_render_process_host.h"
 #include "content/browser/renderer_host/render_view_host.h"
 #include "content/browser/renderer_host/test_render_view_host.h"
 #include "content/browser/site_instance.h"
 #include "content/browser/tab_contents/navigation_entry.h"
 #include "content/browser/tab_contents/tab_contents.h"
 #include "content/browser/webui/empty_web_ui_factory.h"
 #include "content/common/content_client.h"
+#include "content/common/url_constants.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace {
 
 // TODO(estade): this shouldn't need to be chrome:, but it does (or else GURL
 // doesn't think that the webui URLs have a host). Figure out where this is
 // coming from and fix it.
 const char kWebUIScheme[] = "chrome";
+const char kSameAsAnyInstanceURL[] = "about:internets";
 
 class SiteInstanceTestWebUIFactory : public content::EmptyWebUIFactory {
  public:
   virtual bool UseWebUIForURL(Profile* profile, const GURL& url) const {
     return HasWebUIScheme(url);
   }
   virtual bool HasWebUIScheme(const GURL& url) const {
     return url.SchemeIs(kWebUIScheme);
   }
 };
 
 class SiteInstanceTestBrowserClient : public content::ContentBrowserClient {
  public:
   virtual content::WebUIFactory* GetWebUIFactory() {
     return &factory_;
   }
 
+  virtual bool IsURLSameAsAnySiteInstance(const GURL& url) {
+    return url.spec() == kSameAsAnyInstanceURL;
+  }
+
  private:
   SiteInstanceTestWebUIFactory factory_;
 };
 
 class SiteInstanceTest : public testing::Test {
  public:
   SiteInstanceTest()
       : ui_thread_(BrowserThread::UI, &message_loop_),
         old_browser_client_(NULL) {
   }
@@ skipping 235 matching lines @@
 // Test of distinguishing URLs from different sites.  Most of this logic is
 // tested in RegistryControlledDomainTest.  This test focuses on URLs with
 // different schemes or ports.
 TEST_F(SiteInstanceTest, IsSameWebSite) {
   GURL url_foo = GURL("http://foo/a.html");
   GURL url_foo2 = GURL("http://foo/b.html");
   GURL url_foo_https = GURL("https://foo/a.html");
   GURL url_foo_port = GURL("http://foo:8080/a.html");
   GURL url_javascript = GURL("javascript:alert(1);");
   GURL url_crash = GURL(chrome::kAboutCrashURL);
-  GURL url_hang = GURL(chrome::kAboutHangURL);
-  GURL url_shorthang = GURL(chrome::kAboutShorthangURL);
+  GURL url_browser_specified = GURL(kSameAsAnyInstanceURL);
 
   // Same scheme and port -> same site.
   EXPECT_TRUE(SiteInstance::IsSameWebSite(NULL, url_foo, url_foo2));
 
   // Different scheme -> different site.
   EXPECT_FALSE(SiteInstance::IsSameWebSite(NULL, url_foo, url_foo_https));
 
   // Different port -> same site.
   // (Changes to document.domain make renderer ignore the port.)
   EXPECT_TRUE(SiteInstance::IsSameWebSite(NULL, url_foo, url_foo_port));
 
   // JavaScript links should be considered same site for anything.
   EXPECT_TRUE(SiteInstance::IsSameWebSite(NULL, url_javascript, url_foo));
   EXPECT_TRUE(SiteInstance::IsSameWebSite(NULL, url_javascript, url_foo_https));
   EXPECT_TRUE(SiteInstance::IsSameWebSite(NULL, url_javascript, url_foo_port));
 
-  // The crash/hang URLs should also be treated as same site.  (Bug 1143809.)
+  // The URLs specified by the ContentBrowserClient should also be treated as
+  // same site.
   EXPECT_TRUE(SiteInstance::IsSameWebSite(NULL, url_crash, url_foo));
-  EXPECT_TRUE(SiteInstance::IsSameWebSite(NULL, url_hang, url_foo));
-  EXPECT_TRUE(SiteInstance::IsSameWebSite(NULL, url_shorthang, url_foo));
+  EXPECT_TRUE(
+      SiteInstance::IsSameWebSite(NULL, url_browser_specified, url_foo));
 }
 
 // Test to ensure that there is only one SiteInstance per site in a given
 // BrowsingInstance, when process-per-site is not in use.
 TEST_F(SiteInstanceTest, OneSiteInstancePerSite) {
   int deleteCounter = 0;
   TestBrowsingInstance* browsing_instance =
       new TestBrowsingInstance(NULL, &deleteCounter);
   browsing_instance->use_process_per_site = false;
 
@@ skipping 234 matching lines @@
       GURL("chrome-extension://baz/bar")));
   EXPECT_EQ(s5a, s5b);
 
   // The derived profiles with the different sites.
   scoped_refptr<SiteInstance> s6a(instance1->GetSiteInstanceForURL(
       GURL("chrome-extension://baz/bar")));
   scoped_refptr<SiteInstance> s6b(instance3->GetSiteInstanceForURL(
       GURL("chrome-extension://foo/boo")));
   EXPECT_NE(s6a, s6b);
 }