Support getting the font list in Pepper. This currently only works out of

ppapi/proxy/ppb_font_proxy.cc

Index: ppapi/proxy/ppb_font_proxy.cc
===================================================================
--- ppapi/proxy/ppb_font_proxy.cc	(revision 85766)
+++ ppapi/proxy/ppb_font_proxy.cc	(working copy)
@@ -9,7 +9,9 @@
 #include "ppapi/proxy/plugin_dispatcher.h"
 #include "ppapi/proxy/ppapi_messages.h"
 #include "ppapi/proxy/ppb_image_data_proxy.h"
+#include "ppapi/proxy/serialized_var.h"
 #include "ppapi/shared_impl/resource_object_base.h"
+#include "ppapi/thunk/enter.h"
 #include "ppapi/thunk/ppb_image_data_api.h"
 #include "ppapi/thunk/thunk.h"
 
@@ -61,6 +63,28 @@
   return &info;
 }
 
+::ppapi::thunk::PPB_Font_FunctionAPI* PPB_Font_Proxy::AsFont_FunctionAPI() {
+  return this;
+}
+
+PP_Var PPB_Font_Proxy::GetFontFamilies(PP_Instance instance) {
+  PluginDispatcher* dispatcher = PluginDispatcher::GetForInstance(instance);
+  if (!dispatcher)
+    return PP_MakeUndefined();
+
+  // Assume the font families don't change, so we can cache the result globally.
+  static std::string families;
+  if (families.empty()) {
+    dispatcher->SendToBrowser(
+        new PpapiHostMsg_PPBFont_GetFontFamilies(&families));
+  }
+
+  PP_Var result;

[viettrungluu, 2011/05/18 21:07:46]

Why don't we have a helper for these three lines of code? It seems like a common
use case. (Or why doesn't MakeString() just return a PP_Var?)

[brettw, 2011/05/18 21:14:38]

Yeah, I've been thinking about improving MakeString but this huge patch seemed
like the wrong time to do it. The var-making helpers are in pp_var.h, but since
plugins can't make strings and objects, we don't have helpers to avoid
confusion.

+  result.type = PP_VARTYPE_STRING;
+  result.value.as_id = PluginVarTracker::GetInstance()->MakeString(families);
+  return result;
+}
+
 bool PPB_Font_Proxy::OnMessageReceived(const IPC::Message& msg) {
   // There aren't any font messages.
   NOTREACHED();