TraceSubscriber implementation that writes to a file.

content/browser/trace_subscriber_stdio_unittest.cc

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/browser/trace_subscriber_stdio.h"

[Paweł Hajdan Jr., 2011/05/19 16:26:49]

nit: Add an empty line below.

[lain Merrick, 2011/05/19 16:38:02]

Done.

+#include "base/memory/scoped_ptr.h"
+#include "base/memory/scoped_temp_dir.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "testing/platform_test.h"

[Paweł Hajdan Jr., 2011/05/19 16:26:49]

nit: This doesn't seem to use PlatformTest.

[lain Merrick, 2011/05/19 16:38:02]

Done.

+
+namespace {
+
+class TraceSubscriberStdioTest : public testing::Test {
+ public:
+  virtual void SetUp() {
+    trace_dir_.reset(new ScopedTempDir());
+    ASSERT_TRUE(trace_dir_->CreateUniqueTempDir());
+    trace_file_ = trace_dir_->path().AppendASCII("trace.txt");
+  }
+  virtual void TearDown() {
+    trace_dir_.reset();

[Paweł Hajdan Jr., 2011/05/19 16:26:49]

This shouldn't be needed. Please remove entire TearDown then.

[lain Merrick, 2011/05/19 16:38:02]

Done.

+  }
+  std::string ReadTraceFile() {
+    std::string result;
+    EXPECT_TRUE(file_util::ReadFileToString(trace_file_, &result));
+    return result;
+  }
+
+  scoped_ptr<ScopedTempDir> trace_dir_;

[Paweł Hajdan Jr., 2011/05/19 16:26:49]

ScopedTempDir shouldn't need a scoped_ptr. ScopedTempDir trace_dir_ should be
sufficient. The entire test fixture class is created and destroyed for each test
case.

[lain Merrick, 2011/05/19 16:38:02]

Done.

+  FilePath trace_file_;
+};
+
+TEST_F(TraceSubscriberStdioTest, CanWriteBracketedDataToFile) {
+  TraceSubscriberStdio subscriber(trace_file_);
+  subscriber.OnTraceDataCollected("[foo]");
+  subscriber.OnTraceDataCollected("[bar]");
+  EXPECT_TRUE(subscriber.IsValid());
+
+  subscriber.OnEndTracingComplete();
+  EXPECT_FALSE(subscriber.IsValid());
+
+  EXPECT_EQ("[foo,bar,]", ReadTraceFile());
+}
+
+}  // namespace
+