Include crypto_unittests for Valgrind, Heapcheck, and TSAN

masters/master.chromium.memory/master.cfg

Index: masters/master.chromium.memory/master.cfg
===================================================================
--- masters/master.chromium.memory/master.cfg	(revision 85872)
+++ masters/master.chromium.memory/master.cfg	(working copy)
@@ -184,6 +184,7 @@
     slave_type='Tester',
     build_url=chromium_linux_valgrind_archive,
     tests=['valgrind_base',
+           'valgrind_crypto',
            'valgrind_ui_3_of_8',
            'valgrind_ui_4_of_8',
            ],
@@ -229,6 +230,7 @@
     build_url=chromium_linux_valgrind_archive,
     tests=['tsan_app',
            'tsan_base',
+           'tsan_crypto',

[Timur Iskhodzhanov, 2011/05/19 16:51:39]

Are there any threads in crypto tests?

[Ryan Sleevi, 2011/05/20 01:35:33]

Not directly, but possibly in the underlying libraries.

I added it to tsan given that all of the tests were previously covered by
tsan_base, and the goal was to restore equivalent coverage. I'm not sure if tsan
is necessary though.

            'tsan_googleurl',
            'tsan_net',
            'tsan_ipc',
@@ -271,6 +273,7 @@
     slave_type='Builder',
     options=['app_unittests',
              'base_unittests',
+             'crypto_unittests',
              'googleurl_unittests',
              'ipc_tests',
              'media_unittests',
@@ -301,6 +304,7 @@
              'sync_unit_tests',
              'ipc_tests',
              'base_unittests',
+             'crypto_unittests',
              'net_unittests',
              'gfx_unittests',
              'unit_tests',
@@ -316,6 +320,7 @@
            'heapcheck_sync',
            'heapcheck_ipc',
            'heapcheck_base',
+           'heapcheck_crypto',
            'heapcheck_net',
            'heapcheck_gfx',
            'heapcheck_unit',
@@ -362,6 +367,7 @@
         'gclient_env': {'GYP_DEFINES' : valgrind_mac_gyp_defines} },
     tests=['valgrind_app',

[Timur Iskhodzhanov, 2011/05/19 16:51:39]

Can you please add a CAPS comment before the tests=[ line describing that one
should add the tests to the build target before adding the tests runs?

            'valgrind_base',
+           'valgrind_crypto',

[Timur Iskhodzhanov, 2011/05/19 16:51:39]

How much time do they take under Valgrind on Mac?

[Ryan Sleevi, 2011/05/20 01:35:33]

I'm not sure. Previously these tests were part of valgrind_base, which is why I
placed everything to go with the base counterpart. However, my understanding is
that tests are listed "quickest to slowest", so perhaps this isn't the right
place?

[Timur Iskhodzhanov, 2011/05/20 08:39:11]

Looks like the Mac/Valgrind order is closer to alphabetic or just random :)
OK, you may leave the order this way.

On 2011/05/20 01:35:33, Ryan Sleevi wrote:

            'valgrind_googleurl',
            'valgrind_ipc',
            'valgrind_media',
@@ -382,6 +388,7 @@
         'gclient_env': {'GYP_DEFINES' : valgrind_mac_gyp_defines} },
     tests=['tsan_app',

[Timur Iskhodzhanov, 2011/05/19 16:51:39]

ditto: comment

            'tsan_base',
+           'tsan_crypto',
            'tsan_googleurl',
            'tsan_net',
            'tsan_ipc',
@@ -454,10 +461,12 @@
 f_chromium_rel_chromeos_valgrind_tests_2 = F_CR_OS(
     target='Release',
     tests=['valgrind_base',
+           'valgrind_crypto',
            'valgrind_ui_3_of_8',
            'valgrind_ui_4_of_8',
            ],
     options=['base_unittests',
+             'crypto_unittests',
              'ui_tests'],
     factory_properties={
       'needs_valgrind' : True,
@@ -511,6 +520,7 @@
       'tsan_media',
       'tsan_ipc',
       'tsan_base',
+      'tsan_crypto',
       'tsan_net',
     ],
     project='all.sln;chromium_builder_dbg_tsan_win',

[Timur Iskhodzhanov, 2011/05/19 16:51:39]

ditto: you need to add crypto_unittests dependency to this target as well.

[Ryan Sleevi, 2011/05/20 01:35:33]

Thanks. Similar with Mac, it is also already in place.