Added 3 more functions in popups.py

Added 3 more functions in popups.py
testUnblockedPopupShowsInHistory
testBlockedPopupNotShowInHistory
testUnblockedPopupAddedToOmnibox

removed GetOmniboxMatchesFor from omnibox.py and added to test_utils.py

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86198

[Nirnimesh, 2011-05-19 06:14:45]

http://codereview.chromium.org/7043026/diff/4001/popups.py
File popups.py (right):

http://codereview.chromium.org/7043026/diff/4001/popups.py#newcode26
popups.py:26: 
remove spaces from this line

http://codereview.chromium.org/7043026/diff/4001/popups.py#newcode146
popups.py:146: file_url = self.GetFileURLForPath(os.path.join(
I've made GetFileURLForPath easier to use. Now you can:

file_url = self.GetFileURLForDataPath('popup_blocker', 'popup-window-open.html')


I guess I forgot to update other instances in this script, but please use this
simpler format for new tests

http://codereview.chromium.org/7043026/diff/4001/popups.py#newcode157
popups.py:157: Currently failing because of issue # 47935.
remove this line. Disable this test in PYAUTO_TESTS

http://codereview.chromium.org/7043026/diff/4001/popups.py#newcode159
popups.py:159: file_url = self.GetFileURLForPath(os.path.join(
same here

http://codereview.chromium.org/7043026/diff/4001/popups.py#newcode164
popups.py:164: self.assertEqual(1, len(history))
merge with previous line

http://codereview.chromium.org/7043026/diff/4001/popups.py#newcode168
popups.py:168: file_url = self.GetFileURLForPath(os.path.join(
same comment as above

http://codereview.chromium.org/7043026/diff/4001/popups.py#newcode173
popups.py:173: search_string = 'data:text/html,<title>Popup Success!</title> \
why not do an omnibox search for something saner, either the url or title

[aocampo, 2011-05-20 00:36:05]

http://codereview.chromium.org/7043026/diff/4001/popups.py
File popups.py (right):

http://codereview.chromium.org/7043026/diff/4001/popups.py#newcode146
popups.py:146: file_url = self.GetFileURLForPath(os.path.join(
On 2011/05/19 06:14:45, Nirnimesh wrote:
> I've made GetFileURLForPath easier to use. Now you can:
> 
> file_url = self.GetFileURLForDataPath('popup_blocker',
'popup-window-open.html')
> 
> 
> I guess I forgot to update other instances in this script, but please use this
> simpler format for new tests

Done.

http://codereview.chromium.org/7043026/diff/4001/popups.py#newcode157
popups.py:157: Currently failing because of issue # 47935.
On 2011/05/19 06:14:45, Nirnimesh wrote:
> remove this line. Disable this test in PYAUTO_TESTS

Done.

http://codereview.chromium.org/7043026/diff/4001/popups.py#newcode159
popups.py:159: file_url = self.GetFileURLForPath(os.path.join(
On 2011/05/19 06:14:45, Nirnimesh wrote:
> same here

Done.

http://codereview.chromium.org/7043026/diff/4001/popups.py#newcode164
popups.py:164: self.assertEqual(1, len(history))
On 2011/05/19 06:14:45, Nirnimesh wrote:
> merge with previous line

Done.

http://codereview.chromium.org/7043026/diff/4001/popups.py#newcode168
popups.py:168: file_url = self.GetFileURLForPath(os.path.join(
On 2011/05/19 06:14:45, Nirnimesh wrote:
> same comment as above

Done.

http://codereview.chromium.org/7043026/diff/4001/popups.py#newcode173
popups.py:173: search_string = 'data:text/html,<title>Popup Success!</title> \
The html test file already provided isn't written in correct html format so when
you check for the omnibox results, the url and the contents are the same and
weird looking.
On 2011/05/19 06:14:45, Nirnimesh wrote:
> why not do an omnibox search for something saner, either the url or title

[Nirnimesh, 2011-05-20 01:39:50]

LGTM with minor nits.

Please use the 'commit' checkbox to commit after making the fixes.

Thanks!

http://codereview.chromium.org/7043026/diff/11001/omnibox.py
File omnibox.py (right):

http://codereview.chromium.org/7043026/diff/11001/omnibox.py#newcode255
omnibox.py:255: split_url.scheme, windex=windex)
indent this only by 4 chars wrt previous line

http://codereview.chromium.org/7043026/diff/11001/omnibox.py#newcode261
omnibox.py:261: search_term, windex=windex)
ditto

[commit-bot: I haz the power, 2011-05-20 21:04:42]

Can't apply patch for file chrome/test/functional/test_utils.py.
patching file chrome/test/functional/test_utils.py
Hunk #1 FAILED at 234.
1 out of 1 hunk FAILED -- saving rejects to file
chrome/test/functional/test_utils.py.rej

[aocampo, 2011-05-20 21:04:45]

http://codereview.chromium.org/7043026/diff/11001/omnibox.py
File omnibox.py (right):

http://codereview.chromium.org/7043026/diff/11001/omnibox.py#newcode255
omnibox.py:255: split_url.scheme, windex=windex)
On 2011/05/20 01:39:50, Nirnimesh wrote:
> indent this only by 4 chars wrt previous line

Done.

http://codereview.chromium.org/7043026/diff/11001/omnibox.py#newcode261
omnibox.py:261: search_term, windex=windex)
On 2011/05/20 01:39:50, Nirnimesh wrote:
> ditto

Done.

[Nirnimesh, 2011-05-20 21:10:16]

On 2011/05/20 21:04:42, commit-bot wrote:
> Can't apply patch for file chrome/test/functional/test_utils.py.
> patching file chrome/test/functional/test_utils.py
> Hunk #1 FAILED at 234.
> 1 out of 1 hunk FAILED -- saving rejects to file
> chrome/test/functional/test_utils.py.rej

Please merge (gclient sync), re-upload and attempt to commit again.

[commit-bot: I haz the power, 2011-05-20 22:31:32]

Presubmit check for 7043026-16002 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit Warnings **
Found line ending with white spaces in:

***************
chrome/test/functional/popups.py, line 143
chrome/test/functional/popups.py, line 146
chrome/test/functional/popups.py, line 154
chrome/test/functional/popups.py, line 157
chrome/test/functional/popups.py, line 161
chrome/test/functional/popups.py, line 162
chrome/test/functional/popups.py, line 165
chrome/test/functional/popups.py, line 175
chrome/test/functional/popups.py, line 176
***************

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[commit-bot: I haz the power, 2011-05-20 23:57:38]

Try job failure for 7043026-20001 on mac:
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number...

[commit-bot: I haz the power, 2011-05-21 02:09:54]

Change committed as 86198