Multi-tab selection: Renaming TabStripModelObserver::TabSelectedAt to ActiveTabChanged

chrome/browser/tabs/tab_strip_model_observer.h

Index: chrome/browser/tabs/tab_strip_model_observer.h
diff --git a/chrome/browser/tabs/tab_strip_model_observer.h b/chrome/browser/tabs/tab_strip_model_observer.h
index ba9df25fd7183f1fb16d003f1131ed5aca9356c2..001c2c952c5cbcf84836c61bb3c272f59ca72249 100644
--- a/chrome/browser/tabs/tab_strip_model_observer.h
+++ b/chrome/browser/tabs/tab_strip_model_observer.h
@@ -76,10 +76,10 @@ class TabStripModelObserver {
   // TabActivatedAt (or something) and have TabSelectionChanged as well.
   // TabSelectedAt. This requires renaming everyone to use new terms instead of
   // selection.
-  virtual void TabSelectedAt(TabContentsWrapper* old_contents,
-                             TabContentsWrapper* new_contents,
-                             int index,
-                             bool user_gesture);
+  virtual void TabActivatedAt(TabContentsWrapper* old_contents,

[sky, 2011/05/19 19:40:12]

Thanks for getting around to this. I think we want two methods to cover the
different cases:

TabSelectionChanged() <- invoked any time the selection changes in some way.

ActiveTabChanged() <- invoked only if the active tab changed. I think most folks
that override TabSelectedAt now only care about this.

[dpapad, 2011/05/19 20:10:04]

I have added a TabSelectionChanged() method in the CL linked on the description
of this CL (http://codereview.chromium.org/6933037/). But this one (7043020) has
to land before 6933037. Also, do you think it is necessary to re-rename
TabActivatedAt to ActiveTabChanged? I just followed the name suggested in the
comments. 

[sky, 2011/05/19 20:56:15]

I think ActiveTabChanged is clearer. It also lines up nicely with
ActiveTabClicked.

[dpapad, 2011/05/24 02:16:35]

Done.

+                              TabContentsWrapper* new_contents,
+                              int index,
+                              bool user_gesture);
 
   // The specified TabContents at |from_index| was moved to |to_index|.
   virtual void TabMoved(TabContentsWrapper* contents,