chrome/browser/ui/views/frame/browser_view.h - Issue 7043020: Multi-tab selection: Renaming TabStripModelObserver::TabSelectedAt to ActiveTabChanged

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_view.h

Issue 7043020: Multi-tab selection: Renaming TabStripModelObserver::TabSelectedAt to ActiveTabChanged (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Updating TODO comments Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/compact_nav/compact_location_bar_view_host.cc ('k') | chrome/browser/ui/views/frame/browser_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/frame/browser_view.h

diff --git a/chrome/browser/ui/views/frame/browser_view.h b/chrome/browser/ui/views/frame/browser_view.h

index 150739f3f5b13332e1d6b03e9f8c4cdf59067f5f..6d593233217c34a4bbae401d29d437576242ce95 100644

--- a/chrome/browser/ui/views/frame/browser_view.h

+++ b/chrome/browser/ui/views/frame/browser_view.h

@@ -356,10 +356,10 @@ class BrowserView : public BrowserBubbleHost,

// Overridden from TabStripModelObserver:

virtual void TabDetachedAt(TabContentsWrapper* contents, int index) OVERRIDE;

virtual void TabDeselected(TabContentsWrapper* contents) OVERRIDE;

- virtual void TabSelectedAt(TabContentsWrapper* old_contents,

- TabContentsWrapper* new_contents,

- int index,

- bool user_gesture) OVERRIDE;

+ virtual void ActiveTabChanged(TabContentsWrapper* old_contents,

+ TabContentsWrapper* new_contents,

+ int index,

+ bool user_gesture) OVERRIDE;

virtual void TabReplacedAt(TabStripModel* tab_strip_model,

TabContentsWrapper* old_contents,

TabContentsWrapper* new_contents,

@@ -540,7 +540,7 @@ class BrowserView : public BrowserBubbleHost,

void UpdateAcceleratorMetrics(const views::Accelerator& accelerator,

int command_id);

- // Invoked from TabSelectedAt or when instant is made active. If

+ // Invoked from ActiveTabChanged or when instant is made active. If

// |change_tab_contents| is true, |new_contents| is added to the view

// hierarchy, if |change_tab_contents| is false, it's assumed |new_contents|

// has already been added to the view hierarchy.