chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm - Issue 7043020: Multi-tab selection: Renaming TabStripModelObserver::TabSelectedAt to ActiveTabChanged

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

Issue 7043020: Multi-tab selection: Renaming TabStripModelObserver::TabSelectedAt to ActiveTabChanged (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Updating TODO comments Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

diff --git a/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm b/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

index 5d2d01ac628a7a2b18d18db47baa9aac59434058..ef54b4506e18189e722302b81b6ff1fa5e9d5151 100644

--- a/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

+++ b/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

@@ -1268,8 +1268,8 @@ class NotificationBridge : public NotificationObserver {

DCHECK_EQ(oldContents->tab_contents(), [oldController tabContents]);

// Simply create a new TabContentsController for |newContents| and place it

- // into the array, replacing |oldContents|. A TabSelectedAt notification will

- // follow, at which point we will install the new view.

+ // into the array, replacing |oldContents|. A ActiveTabChanged notification

+ // will follow, at which point we will install the new view.

scoped_nsobject<TabContentsController> newController(

[[TabContentsController alloc]

initWithContents:newContents->tab_contents()

« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | chrome/browser/ui/cocoa/tabs/tab_strip_model_observer_bridge.h » ('j') | no next file with comments »