Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Unified Diff: net/proxy/network_delegate_error_observer_unittest.cc

Issue 7043007: Kill URLRequestJobTracker. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix windows build. Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/proxy/network_delegate_error_observer_unittest.cc
diff --git a/net/proxy/network_delegate_error_observer_unittest.cc b/net/proxy/network_delegate_error_observer_unittest.cc
index f76f2d06022543b2d7a73091f376b6b659912474..9f5caf0582fea84b59b85c26c9798a73d1580c84 100644
--- a/net/proxy/network_delegate_error_observer_unittest.cc
+++ b/net/proxy/network_delegate_error_observer_unittest.cc
@@ -15,6 +15,7 @@ DISABLE_RUNNABLE_METHOD_REFCOUNT(net::NetworkDelegateErrorObserver);
namespace net {
namespace {
+
class TestNetworkDelegate : public net::NetworkDelegate {
public:
TestNetworkDelegate() : got_pac_error_(false) {}
@@ -40,6 +41,8 @@ class TestNetworkDelegate : public net::NetworkDelegate {
virtual void OnBeforeRedirect(URLRequest* request,
const GURL& new_location) {}
virtual void OnResponseStarted(URLRequest* request) {}
+ virtual void OnBytesRead(const URLRequest& /* request */,
rvargas (doing something else) 2011/05/18 21:45:18 nit: I would follow the current style of not comme
willchan no longer on Chromium 2011/05/18 23:55:55 I'm going to fix the rest. The style guide explici
rvargas (doing something else) 2011/05/19 00:40:33 Sure, I know about the style guide, but that is no
willchan no longer on Chromium 2011/05/19 23:39:18 I think we've documented all our differences/quirk
rvargas (doing something else) 2011/05/20 00:37:31 I just don't see the reason for sometimes saying "
willchan no longer on Chromium 2011/05/20 01:08:40 OK, I think most of this seems to be your personal
rvargas (doing something else) 2011/05/20 02:50:00 I did a search under /chrome/ and I found very few
willchan no longer on Chromium 2011/05/20 22:57:38 Fair enough. I'll try to be consistent with existi
+ int /* bytes_read */) {}
virtual void OnCompleted(URLRequest* request) {}
virtual void OnURLRequestDestroyed(URLRequest* request) {}
virtual void OnHttpTransactionDestroyed(uint64 request_id) {}

Powered by Google App Engine
This is Rietveld 408576698