Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Unified Diff: net/url_request/url_request_test_util.cc

Issue 7043007: Kill URLRequestJobTracker. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments. Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_test_util.cc
diff --git a/net/url_request/url_request_test_util.cc b/net/url_request/url_request_test_util.cc
index fff1d8ba4d2d0a37194b301abc52c5a21239dab1..818b56b632a855a310c1d6d7fad89af0e76ddf55 100644
--- a/net/url_request/url_request_test_util.cc
+++ b/net/url_request/url_request_test_util.cc
@@ -248,28 +248,28 @@ TestNetworkDelegate::TestNetworkDelegate()
TestNetworkDelegate::~TestNetworkDelegate() {}
int TestNetworkDelegate::OnBeforeURLRequest(
- net::URLRequest* request,
- net::CompletionCallback* callback,
- GURL* new_url) {
+ net::URLRequest* /* request */,
+ net::CompletionCallback* /* callback */,
+ GURL* /* new_url */) {
created_requests_++;
return net::OK;
}
int TestNetworkDelegate::OnBeforeSendHeaders(
- uint64 request_id,
- net::CompletionCallback* callback,
- net::HttpRequestHeaders* headers) {
+ uint64 /* request_id */,
+ net::CompletionCallback* /* callback */,
+ net::HttpRequestHeaders* /* headers */) {
return net::OK;
}
void TestNetworkDelegate::OnRequestSent(
- uint64 request_id,
- const net::HostPortPair& socket_address,
- const net::HttpRequestHeaders& headers) {
+ uint64 /* request_id */,
+ const net::HostPortPair& /* socket_address */,
+ const net::HttpRequestHeaders& /* headers */) {
}
-void TestNetworkDelegate::OnBeforeRedirect(net::URLRequest* request,
- const GURL& new_location) {
+void TestNetworkDelegate::OnBeforeRedirect(net::URLRequest* /* request */,
+ const GURL& /* new_location */) {
}
void TestNetworkDelegate::OnResponseStarted(net::URLRequest* request) {
@@ -279,6 +279,10 @@ void TestNetworkDelegate::OnResponseStarted(net::URLRequest* request) {
}
}
+void TestNetworkDelegate::OnRawBytesRead(const net::URLRequest& /* request */,
+ int /* bytes_read */) {
+}
+
void TestNetworkDelegate::OnCompleted(net::URLRequest* request) {
if (request->status().status() == net::URLRequestStatus::FAILED) {
error_count_++;
@@ -286,18 +290,19 @@ void TestNetworkDelegate::OnCompleted(net::URLRequest* request) {
}
}
-void TestNetworkDelegate::OnURLRequestDestroyed(net::URLRequest* request) {
+void TestNetworkDelegate::OnURLRequestDestroyed(
+ net::URLRequest* /* request */) {
destroyed_requests_++;
}
-void TestNetworkDelegate::OnHttpTransactionDestroyed(uint64 request_id) {
+void TestNetworkDelegate::OnHttpTransactionDestroyed(uint64 /* request_id */) {
}
net::URLRequestJob* TestNetworkDelegate::OnMaybeCreateURLRequestJob(
- net::URLRequest* request) {
+ net::URLRequest* /* request */) {
return NULL;
}
-void TestNetworkDelegate::OnPACScriptError(int line_number,
- const string16& error) {
+void TestNetworkDelegate::OnPACScriptError(int /* line_number */,
+ const string16& /* error */) {
}

Powered by Google App Engine
This is Rietveld 408576698