Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Unified Diff: net/proxy/network_delegate_error_observer_unittest.cc

Issue 7043007: Kill URLRequestJobTracker. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments. Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/proxy/network_delegate_error_observer_unittest.cc
diff --git a/net/proxy/network_delegate_error_observer_unittest.cc b/net/proxy/network_delegate_error_observer_unittest.cc
index f76f2d06022543b2d7a73091f376b6b659912474..8f580e84e81f278c2e3da83c94e0d9501ee26761 100644
--- a/net/proxy/network_delegate_error_observer_unittest.cc
+++ b/net/proxy/network_delegate_error_observer_unittest.cc
@@ -15,6 +15,7 @@ DISABLE_RUNNABLE_METHOD_REFCOUNT(net::NetworkDelegateErrorObserver);
namespace net {
namespace {
+
class TestNetworkDelegate : public net::NetworkDelegate {
public:
TestNetworkDelegate() : got_pac_error_(false) {}
@@ -24,29 +25,32 @@ class TestNetworkDelegate : public net::NetworkDelegate {
private:
// net::NetworkDelegate:
- virtual int OnBeforeURLRequest(URLRequest* request,
- CompletionCallback* callback,
- GURL* new_url) {
+ virtual int OnBeforeURLRequest(URLRequest* /* request */,
+ CompletionCallback* /* callback */,
+ GURL* /* new_url */) {
return net::OK;
}
- virtual int OnBeforeSendHeaders(uint64 request_id,
- CompletionCallback* callback,
- HttpRequestHeaders* headers) {
+ virtual int OnBeforeSendHeaders(uint64 /* request_id */,
+ CompletionCallback* /* callback */,
+ HttpRequestHeaders* /* headers */) {
return net::OK;
}
- virtual void OnRequestSent(uint64 request_id,
- const HostPortPair& socket_address,
- const HttpRequestHeaders& headers) {}
- virtual void OnBeforeRedirect(URLRequest* request,
- const GURL& new_location) {}
- virtual void OnResponseStarted(URLRequest* request) {}
- virtual void OnCompleted(URLRequest* request) {}
- virtual void OnURLRequestDestroyed(URLRequest* request) {}
- virtual void OnHttpTransactionDestroyed(uint64 request_id) {}
- virtual URLRequestJob* OnMaybeCreateURLRequestJob(URLRequest* request) {
+ virtual void OnRequestSent(uint64 /* request_id */,
+ const HostPortPair& /* socket_address */,
+ const HttpRequestHeaders& /* headers */) {}
+ virtual void OnBeforeRedirect(URLRequest* /* request */,
+ const GURL& /* new_location */) {}
+ virtual void OnResponseStarted(URLRequest* /* request */) {}
+ virtual void OnRawBytesRead(const URLRequest& /* request */,
+ int /* bytes_read */) {}
+ virtual void OnCompleted(URLRequest* /* request */) {}
+ virtual void OnURLRequestDestroyed(URLRequest* /* request */) {}
+ virtual void OnHttpTransactionDestroyed(uint64 /* request_id */) {}
+ virtual URLRequestJob* OnMaybeCreateURLRequestJob(URLRequest* /* request */) {
return NULL;
}
- virtual void OnPACScriptError(int line_number, const string16& error) {
+ virtual void OnPACScriptError(int /* line_number */,
+ const string16& /* error */) {
got_pac_error_ = true;
}

Powered by Google App Engine
This is Rietveld 408576698