Print Preview: Remembering last used printer.

chrome/browser/ui/webui/print_preview_handler.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_WEBUI_PRINT_PREVIEW_HANDLER_H_
 #define CHROME_BROWSER_UI_WEBUI_PRINT_PREVIEW_HANDLER_H_
 #pragma once
 
 #include "base/memory/ref_counted.h"
 #include "base/memory/weak_ptr.h"
@@ skipping 62 matching lines @@
   void HandleClosePreviewTab(const ListValue* args);
 
   // Send the printer capabilities to the Web UI.
   // |settings_info| contains printer capabilities information.
   void SendPrinterCapabilities(const DictionaryValue& settings_info);
 
   // Send the default printer to the Web UI.
   void SendDefaultPrinter(const StringValue& default_printer);
 
   // Send the list of printers to the Web UI.
-  void SendPrinterList(const ListValue& printers,
-                       const FundamentalValue& default_printer_index);
+  void SendPrinterList(const ListValue& printers);
 
   // Helper function to get the initiator tab for the print preview tab.
   TabContents* GetInitiatorTab();
 
   // Helper function to close the print preview tab.
   void ClosePrintPreviewTab();
 
   // Helper function to activate the initiator tab and close the preview tab.
   void ActivateInitiatorTabAndClosePreviewTab();
 
   // Adds all the recorded stats taken so far to histogram counts.
   void ReportStats();
 
   // Pointer to current print system.
   scoped_refptr<printing::PrintBackend> print_backend_;
 
   // The underlying dialog object.
   scoped_refptr<SelectFileDialog> select_file_dialog_;
 
   static FilePath* last_saved_path_;
+  static std::string last_used_printer_;

[Lei Zhang, 2011/06/08 00:41:59]

I don't think you are allowed to use non-POD static variable.

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Static_and_Glo...

[dpapad, 2011/06/08 16:33:56]

Done.

 
   // A count of how many requests received to regenerate preview data.
   // Initialized to 0 then incremented and emitted to a histogram.
   int regenerate_preview_request_count_;
 
   // A count of how many requests received to show manage printers dialog.
   int manage_printers_dialog_request_count_;
 
   // Whether we have already logged a failed print preview.
   bool reported_failed_preview_;
 
   // Whether we have already logged the number of printers this session.
   bool has_logged_printers_count_;
 
   DISALLOW_COPY_AND_ASSIGN(PrintPreviewHandler);
 };
 
 #endif  // CHROME_BROWSER_UI_WEBUI_PRINT_PREVIEW_HANDLER_H_