Issue 7042028: Detect & destroy dead conflictresolver paths.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7042028: Detect & destroy dead conflictresolver paths. (Closed)

Created:
9 years, 7 months ago by ncarter (slow)

Modified:
9 years, 7 months ago

Reviewers:
commit-bot: I haz the power, Nicolas Zea

CC:
chromium-reviews, Raghu Simha, ncarter (slow), Paweł Hajdan Jr., tim (not reviewing), idana

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Detect & destroy dead conflictresolver paths. Remove useless member from conflictresolver (it was always empty and had no effect). Add histograms to conflictresolver to verify the hypothesis that this code is unreachable in practice. BUG=83006 TEST=unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86157

Patch Set 1 #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -55 lines)			Patch
M	chrome/browser/sync/engine/conflict_resolver.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/sync/engine/conflict_resolver.cc	View	6 chunks	+4 lines, -10 lines	0 comments	Download
M	chrome/browser/sync/engine/syncer.h	View	1 chunk	+0 lines, -21 lines	0 comments	Download
M	chrome/browser/sync/engine/syncer_unittest.cc	View	1 chunk	+0 lines, -18 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Change committed as 86157

Expand Messages | Collapse Messages