Add separate nonce version of connect call.

remoting/client/plugin/chromoting_scriptable_object.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/client/plugin/chromoting_scriptable_object.h"
 
 #include "base/logging.h"
 #include "base/stringprintf.h"
 #include "ppapi/cpp/var.h"
 #include "remoting/client/client_config.h"
@@ skipping 67 matching lines @@
 
   // Statistics.
   AddAttribute(kVideoBandwidthAttribute, Var());
   AddAttribute(kVideoCaptureLatencyAttribute, Var());
   AddAttribute(kVideoEncodeLatencyAttribute, Var());
   AddAttribute(kVideoDecodeLatencyAttribute, Var());
   AddAttribute(kVideoRenderLatencyAttribute, Var());
   AddAttribute(kRoundTripLatencyAttribute, Var());
 
   AddMethod("connect", &ChromotingScriptableObject::DoConnect);
+  AddMethod("connectNonce", &ChromotingScriptableObject::DoConnectNonce);
   AddMethod("connectSandboxed",
             &ChromotingScriptableObject::DoConnectSandboxed);
+  AddMethod("connectSandboxedNonce",
+            &ChromotingScriptableObject::DoConnectSandboxedNonce);

[Wez, 2011/05/20 22:38:59]

Why are you still adding these?

   AddMethod("disconnect", &ChromotingScriptableObject::DoDisconnect);
   AddMethod("submitLoginInfo", &ChromotingScriptableObject::DoSubmitLogin);
   AddMethod("setScaleToFit", &ChromotingScriptableObject::DoSetScaleToFit);
   AddMethod("onIq", &ChromotingScriptableObject::DoOnIq);
 }
 
 bool ChromotingScriptableObject::HasProperty(const Var& name, Var* exception) {
   // TODO(ajwong): Check if all these name.is_string() sentinels are required.
   if (!name.is_string()) {
     *exception = Var("HasProperty expects a string for the name.");
@@ skipping 220 matching lines @@
 
 void ChromotingScriptableObject::SendIq(const std::string& message_xml) {
   Var exception;
   Var cb = GetProperty(Var(kSendIq), &exception);
 
   // Var() means call the object directly as a function rather than calling
   // a method in the object.
   cb.Call(Var(), Var(message_xml), &exception);
 
   if (!exception.is_undefined())
-    LogDebugInfo("Exception when invoking loginChallenge JS callback.");
+    LogDebugInfo("Exception when invoking sendiq JS callback.");

[Wez, 2011/05/20 22:38:59]

Is This the correct callback name?

 }
 
 Var ChromotingScriptableObject::DoConnect(const std::vector<Var>& args,
                                           Var* exception) {
-  if (args.size() != 4) {
+  if (args.size() != 3) {
     *exception = Var("Usage: connect(username, host_jid, auth_token)");
     return Var();
   }
 
+  return DoConnect_(args, exception, false);
+}
+
+Var ChromotingScriptableObject::DoConnectNonce(const std::vector<Var>& args,
+                                               Var* exception) {
+  if (args.size() != 4) {
+    *exception = Var("Usage: connect(username, host_jid, auth_token, nonce)");
+    return Var();
+  }
+
+  return DoConnect_(args, exception, true);
+}
+
+Var ChromotingScriptableObject::DoConnect_(const std::vector<Var>& args,
+                                          Var* exception,
+                                          bool require_nonce) {
   ClientConfig config;
 
   if (!args[0].is_string()) {
     *exception = Var("The username must be a string.");
     return Var();
   }
   config.username = args[0].AsString();
 
   if (!args[1].is_string()) {
     *exception = Var("The host_jid must be a string.");
     return Var();
   }
   config.host_jid = args[1].AsString();
 
   if (!args[2].is_string()) {
     *exception = Var("The auth_token must be a string.");
     return Var();
   }
   config.auth_token = args[2].AsString();
 
-  if (!args[3].is_string()) {
-    *exception = Var("nonce must be a string.");
-    return Var();
+  if (require_nonce) {
+    if (!args[3].is_string()) {
+      *exception = Var("nonce must be a string.");
+      return Var();
+    }
+    config.nonce = args[3].AsString();
   }
-  config.nonce = args[3].AsString();
 
   LogDebugInfo("Connecting to host.");
   instance_->Connect(config);
 
   return Var();
 }
 
 Var ChromotingScriptableObject::DoConnectSandboxed(
     const std::vector<Var>& args, Var* exception) {
+  if (args.size() != 2) {
+    *exception = Var("Usage: connectSandboxed(your_jid, host_jid)");
+    return Var();
+  }
+
+  return DoConnectSandboxed_(args, exception, false);
+}
+
+Var ChromotingScriptableObject::DoConnectSandboxedNonce(
+    const std::vector<Var>& args, Var* exception) {
   if (args.size() != 3) {
     *exception = Var("Usage: connectSandboxed(your_jid, host_jid, nonce)");
     return Var();
   }
 
+  return DoConnectSandboxed_(args, exception, true);
+}
+
+Var ChromotingScriptableObject::DoConnectSandboxed_(
+    const std::vector<Var>& args, Var* exception, bool require_nonce) {
   std::string your_jid;
   if (!args[0].is_string()) {
     *exception = Var("your_jid must be a string.");
     return Var();
   }
   your_jid = args[0].AsString();
 
   std::string host_jid;
   if (!args[1].is_string()) {
     *exception = Var("host_jid must be a string.");
     return Var();
   }
   host_jid = args[1].AsString();
 
   std::string nonce;
-  if (!args[2].is_string()) {
-    *exception = Var("nonce must be a string.");
-    return Var();
+  if (require_nonce) {
+    if (!args[2].is_string()) {
+      *exception = Var("nonce must be a string.");
+      return Var();
+    }
+    nonce = args[2].AsString();
   }
-  nonce = args[2].AsString();
 
   VLOG(1) << "your_jid: " << your_jid << ", host_jid: " << host_jid
           << ", nonce: " << nonce;
   instance_->ConnectSandboxed(your_jid, host_jid, nonce);
 
   return Var();
 }
 
 Var ChromotingScriptableObject::DoDisconnect(const std::vector<Var>& args,
                                              Var* exception) {
@@ skipping 55 matching lines @@
     *exception = Var("response_xml must be a string.");
     return Var();
   }
 
   xmpp_proxy_->OnIq(args[0].AsString());
 
   return Var();
 }
 
 }  // namespace remoting