chrome/test/data/extensions/api_test/window_open/argument_overflow/test.html - Issue 7042021: Check for integer overflow when validating API function arguments.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/extensions/api_test/window_open/argument_overflow/test.html

Issue 7042021: Check for integer overflow when validating API function arguments. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <script>

	2 function check_overflow_check(value) {

	3 try {

	4 chrome.windows.create({ "left": value }, function() { });

	5 } catch (e) {

	6 chrome.test.assertTrue(e.message.indexOf(

	7 "Value must fit in a 32-bit signed integer.") != -1);

	8 chrome.test.succeed();

	9 return;

	10 }

	11 }

	12 chrome.test.runTests([

	13 function overflow2To31() { check_overflow_check(0x80000000); },

	14 function overflowMinus2To31Minus1() { check_overflow_check(-0x80000001); },

	15 function overflow2To32() { check_overflow_check(0x100000000); },

	16 ]);

	17 </script>

OLD	NEW