Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Side by Side Diff: src/ia32/lithium-ia32.h

Issue 7042006: Remove NULL temp operand from ia32 LStoreKeyedSpecializedArrayElement. (Closed)
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/ia32/lithium-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1795 matching lines...) Expand 10 before | Expand all | Expand 10 after
1806 DECLARE_HYDROGEN_ACCESSOR(StoreKeyedFastElement) 1806 DECLARE_HYDROGEN_ACCESSOR(StoreKeyedFastElement)
1807 1807
1808 virtual void PrintDataTo(StringStream* stream); 1808 virtual void PrintDataTo(StringStream* stream);
1809 1809
1810 LOperand* object() { return inputs_[0]; } 1810 LOperand* object() { return inputs_[0]; }
1811 LOperand* key() { return inputs_[1]; } 1811 LOperand* key() { return inputs_[1]; }
1812 LOperand* value() { return inputs_[2]; } 1812 LOperand* value() { return inputs_[2]; }
1813 }; 1813 };
1814 1814
1815 1815
1816 class LStoreKeyedSpecializedArrayElement: public LTemplateInstruction<0, 3, 1> { 1816 class LStoreKeyedSpecializedArrayElement: public LTemplateInstruction<0, 3, 0> {
1817 public: 1817 public:
1818 LStoreKeyedSpecializedArrayElement(LOperand* external_pointer, 1818 LStoreKeyedSpecializedArrayElement(LOperand* external_pointer,
1819 LOperand* key, 1819 LOperand* key,
1820 LOperand* val, 1820 LOperand* val) {
1821 LOperand* temp) {
1822 inputs_[0] = external_pointer; 1821 inputs_[0] = external_pointer;
1823 inputs_[1] = key; 1822 inputs_[1] = key;
1824 inputs_[2] = val; 1823 inputs_[2] = val;
1825 temps_[0] = temp;
1826 } 1824 }
1827 1825
1828 DECLARE_CONCRETE_INSTRUCTION(StoreKeyedSpecializedArrayElement, 1826 DECLARE_CONCRETE_INSTRUCTION(StoreKeyedSpecializedArrayElement,
1829 "store-keyed-specialized-array-element") 1827 "store-keyed-specialized-array-element")
1830 DECLARE_HYDROGEN_ACCESSOR(StoreKeyedSpecializedArrayElement) 1828 DECLARE_HYDROGEN_ACCESSOR(StoreKeyedSpecializedArrayElement)
1831 1829
1832 LOperand* external_pointer() { return inputs_[0]; } 1830 LOperand* external_pointer() { return inputs_[0]; }
1833 LOperand* key() { return inputs_[1]; } 1831 LOperand* key() { return inputs_[1]; }
1834 LOperand* value() { return inputs_[2]; } 1832 LOperand* value() { return inputs_[2]; }
1835 ExternalArrayType array_type() const { 1833 ExternalArrayType array_type() const {
(...skipping 553 matching lines...) Expand 10 before | Expand all | Expand 10 after
2389 2387
2390 DISALLOW_COPY_AND_ASSIGN(LChunkBuilder); 2388 DISALLOW_COPY_AND_ASSIGN(LChunkBuilder);
2391 }; 2389 };
2392 2390
2393 #undef DECLARE_HYDROGEN_ACCESSOR 2391 #undef DECLARE_HYDROGEN_ACCESSOR
2394 #undef DECLARE_CONCRETE_INSTRUCTION 2392 #undef DECLARE_CONCRETE_INSTRUCTION
2395 2393
2396 } } // namespace v8::internal 2394 } } // namespace v8::internal
2397 2395
2398 #endif // V8_IA32_LITHIUM_IA32_H_ 2396 #endif // V8_IA32_LITHIUM_IA32_H_
OLDNEW
« no previous file with comments | « no previous file | src/ia32/lithium-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698