Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 7042006: Remove NULL temp operand from ia32 LStoreKeyedSpecializedArrayElement. (Closed)

Created:
9 years, 7 months ago by Vitaly Repeshko
Modified:
9 years, 7 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Remove NULL temp operand from ia32 LStoreKeyedSpecializedArrayElement. Committed: http://code.google.com/p/v8/source/detail?r=7924

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M src/ia32/lithium-ia32.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Vitaly Repeshko
9 years, 7 months ago (2011-05-18 08:30:40 UTC) #1
danno
LGTM, please check the x64 and arm impls, too.
9 years, 7 months ago (2011-05-18 09:14:05 UTC) #2
Vitaly Repeshko
9 years, 7 months ago (2011-05-18 09:19:57 UTC) #3
On 2011/05/18 09:14:05, danno wrote:
> LGTM, please check the x64 and arm impls, too.

Thanks! The other architectures are fine.

Powered by Google App Engine
This is Rietveld 408576698