Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 7042004: Handle all kind of arguments in the ToBooleanStub. While this is not very (Closed)

Created:
9 years, 7 months ago by Sven Panne
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Handle all kind of arguments in the ToBooleanStub. While this is not very thrilling in itself, it is one of several steps to add type recording to this stub. Removed a duplicate check for null in the ARM stub and made a tiny simplification, removing a sub instruction. As a side note, this change has some positive impact on the performace, e.g. imaging-darkroom is 8.3% faster and ws-ieee754conv is even 19.9% faster. No idea why the speedup is so big in some cases, but never look a gift horse in the mouth... ;-)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -60 lines) Patch
M src/arm/code-stubs-arm.cc View 3 chunks +26 lines, -10 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 2 chunks +0 lines, -19 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +17 lines, -1 line 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Sven Panne
9 years, 7 months ago (2011-05-18 07:46:19 UTC) #1
Kevin Millikin (Chromium)
9 years, 7 months ago (2011-05-18 10:31:57 UTC) #2
LGTM.

It's strange that we specialize the stub for argument register on ARM but not
the other platforms (it's mostly a legacy from the classic code generator).  It
would be interesting to investigate whether that helps optimized code or not
enough to make it worth the bother.

Powered by Google App Engine
This is Rietveld 408576698